Summary: | Fullscreen code assumes all layers use GPU compositing when USE(ACCELERATED_COMPOSITING) | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Dorwin <ddorwin> | ||||||||||
Component: | Platform | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, ddorwin, jer.noble, vangelis | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
David Dorwin
2011-03-29 16:32:23 PDT
Created attachment 87432 [details]
Check isComposited() before using the backing and remove the asserts.
Looks good to me. Comment on attachment 87432 [details] Check isComposited() before using the backing and remove the asserts. View in context: https://bugs.webkit.org/attachment.cgi?id=87432&action=review > Source/WebCore/ChangeLog:9 > + Accelerated compositing may be compiled in but disabled at runtime or for so This sentence looks incomplete. > Source/WebCore/dom/Document.cpp:4924 > + page()->chrome()->client()->setRootFullScreenLayer(m_fullScreenRenderer->layer()->backing()->graphicsLayer()); Your indent is incorrect. (4 space indent in WK unlike chromium with a 2 space indent). > Source/WebCore/dom/Document.cpp:4949 > + page()->chrome()->client()->setRootFullScreenLayer(m_fullScreenRenderer->layer()->backing()->graphicsLayer()); Ditto. Created attachment 88134 [details]
Fixed indent and ChangeLog.
Comment on attachment 88134 [details] Fixed indent and ChangeLog. Rejecting attachment 88134 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2 Last 500 characters of output: mmit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/dom/Document.cpp Hunk #1 succeeded at 4849 (offset -71 lines). Hunk #2 FAILED at 4861. Hunk #3 FAILED at 4874. 2 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/dom/Document.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8330185 Created attachment 88254 [details]
Merged with head
Created attachment 88257 [details]
Merged with head
Comment on attachment 88257 [details] Merged with head Rejecting attachment 88257 [details] from commit-queue. ddorwin@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Comment on attachment 88257 [details] Merged with head Clearing flags on attachment: 88257 Committed r82956: <http://trac.webkit.org/changeset/82956> All reviewed patches have been landed. Closing bug. |