Bug 57373

Summary: Make WinCairo a core builder
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Make WinCairo a core builder.
none
Patch aroben: review+

Brent Fulgham
Reported 2011-03-29 12:01:55 PDT
Make WinCairo a core builder to help reduce build breaks due to ongoing development.
Attachments
Make WinCairo a core builder. (1.62 KB, patch)
2011-03-29 12:12 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
Patch (2.60 KB, patch)
2011-03-29 12:54 PDT, Brent Fulgham 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2011-03-29 12:12:20 PDT
Created attachment 87387 [details] Make WinCairo a core builder.
WebKit Review Bot
Comment 2 2011-03-29 12:15:20 PDT
Attachment 87387 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Brent Fulgham
Comment 3 2011-03-29 12:54:20 PDT
Created attachment 87399 [details] Patch
Adam Roben (:aroben)
Comment 4 2011-03-29 12:56:20 PDT
Comment on attachment 87399 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87399&action=review > Tools/Scripts/update-webkit-support-libs:66 > +print "$extractedVersion compared to $expectedVersion"; > + Whoopsie! Please remove this
Brent Fulgham
Comment 5 2011-03-29 12:58:45 PDT
Whoops! I've removed the debugging message.
Brent Fulgham
Comment 6 2011-03-29 13:56:09 PDT
Landed in http://trac.webkit.org/changeset/82313.
WebKit Review Bot
Comment 7 2011-03-29 15:00:50 PDT
http://trac.webkit.org/changeset/82313 might have broken Windows 7 Release (Tests)
Note You need to log in before you can comment on or make changes to this bug.