Bug 57345

Summary: Web Inspector: split debugger agent into Page and Worker-specific ones
Product: WebKit Reporter: Yury Semikhatsky <yurys>
Component: Web Inspector (Deprecated)Assignee: Yury Semikhatsky <yurys>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, buildbot, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
pfeldman: review+
Patch that compiles none

Yury Semikhatsky
Reported 2011-03-29 08:47:14 PDT
Web Inspector: split debugger agent into Page and Worker-specific ones. All Page-specific interaction should be moved into descendants of InspectorDebuggerAgent and ScriptDebugServer. Workers will have their own implementation of the agent and server.
Attachments
Patch (122.30 KB, patch)
2011-03-30 06:20 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (122.30 KB, patch)
2011-03-30 06:23 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
Patch that compiles (122.02 KB, patch)
2011-03-30 08:22 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-03-30 06:20:25 PDT
Created attachment 87519 [details] Patch
Yury Semikhatsky
Comment 2 2011-03-30 06:23:30 PDT
Created attachment 87520 [details] Patch
Pavel Feldman
Comment 3 2011-03-30 06:37:34 PDT
Comment on attachment 87519 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87519&action=review Please split this at least into 5 patches since it is nearly impossible to follow what is going on here. Conceptually, it is all right. > Source/WebCore/bindings/js/PageScriptDebugServer.cpp:63 > +/* Please remove this comment. > Source/WebCore/bindings/js/PageScriptDebugServer.cpp:72 > +PageScriptDebugServer& PageScriptDebugServer::shared() We don't really need static server.
Yury Semikhatsky
Comment 4 2011-03-30 07:00:40 PDT
Committed r82436: <http://trac.webkit.org/changeset/82436>
Yury Semikhatsky
Comment 5 2011-03-30 07:39:13 PDT
Reopening since the change was rolled out in r82438 due to compilation failures on EFL and Win.
Yury Semikhatsky
Comment 6 2011-03-30 08:22:09 PDT
Created attachment 87539 [details] Patch that compiles Patch with additional changes to build files that should make it compile on EFL and Windows.
Build Bot
Comment 7 2011-03-30 08:22:47 PDT
Attachment 87520 [details] did not build on win: Build output: http://queues.webkit.org/results/8285851
Yury Semikhatsky
Comment 8 2011-03-30 08:26:53 PDT
Committed r82449: <http://trac.webkit.org/changeset/82449>
WebKit Review Bot
Comment 9 2011-03-30 12:23:12 PDT
http://trac.webkit.org/changeset/82436 might have broken WinCE Release (Build)
Note You need to log in before you can comment on or make changes to this bug.