Bug 57334

Summary:

DumpRenderTree on Windows doesn't block access to external URLs, but should (makes some tests fail)

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

jberlin, mjs, zimmermann

Priority:

Keywords:

InRadar, LayoutTestFailure, PlatformOnly

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

URL:

http://build.webkit.org/results/Windows%207%20Release%20%28Tests%29/r82237%20(10912)/http/tests/uri/username-with-no-hostname-pretty-diff.html

Attachments:

Description	Flags
Patch to add "block access to external URLs" logic to DRT/win	none

Adam Roben (:aroben)

Reported 2011-03-29 07:02:18 PDT

http/tests/uri/username-with-no-hostname.html has been failing on Windows since r82189 when its expected results were updated. See the URL for the failure diff.

Attachments
Patch to add "block access to external URLs" logic to DRT/win (2.41 KB, patch) 2011-03-29 08:17 PDT, Adam Roben (:aroben)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2011-03-29 08:15:24 PDT

The test is failing because DRT/win's ResourceLoadDelegate doesn't have the "block access to external URLs" logic that DRT/mac has. That logic was added to DRT/mac in r33491.

Adam Roben (:aroben)

Comment 2 2011-03-29 08:17:03 PDT

Created attachment 87335 [details] Patch to add "block access to external URLs" logic to DRT/win This patch gives DRT/win the same smarts as DRT/mac. However, this causes the test to fail in a different way: the "Blocked access to external URL" message is printed twice (once for the real load, and once for a preload). I don't know why this doesn't happen on Mac.

Adam Roben (:aroben)

Comment 3 2011-03-29 08:27:43 PDT

I checked in new expected results for Windows in r82255. This bug can be used to track the task of adding the URL-blocking logic to DRT.

Adam Roben (:aroben)

Comment 4 2011-03-29 08:28:12 PDT

<rdar://problem/9202302>

Jessie Berlin

Comment 5 2011-03-29 09:11:59 PDT

I think the new expected results for Windows broke WK2 Windows tests: http://build.webkit.org/results/Windows%207%20Release%20(WebKit2%20Tests)/r82253%20(4654)/results.html http://build.webkit.org/results/Windows%207%20Release%20(WebKit2%20Tests)/r82255%20(4655)/results.html

Adam Roben (:aroben)

Comment 6 2011-03-29 10:47:39 PDT

You're right! I'll take care of it.

Adam Roben (:aroben)

Comment 7 2011-03-29 12:44:00 PDT

Added win-wk2 passing results in r82301.

Adam Roben (:aroben)

Comment 8 2011-03-30 12:20:06 PDT

(In reply to comment #2) > Created an attachment (id=87335) [details] > Patch to add "block access to external URLs" logic to DRT/win > > This patch gives DRT/win the same smarts as DRT/mac. However, this causes the test to fail in a different way: the "Blocked access to external URL" message is printed twice (once for the real load, and once for a preload). I don't know why this doesn't happen on Mac. Ooh, it happened once on Mac! http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r82463%20(10201)/http/tests/uri/username-with-no-hostname-pretty-diff.html

Adam Roben (:aroben)

Comment 9 2011-04-13 06:46:45 PDT

*** Bug 58421 has been marked as a duplicate of this bug. ***

Jessie Berlin

Comment 10 2011-04-15 10:46:37 PDT

Added more win-wk2 passing results in http://trac.webkit.org/changeset/83989

Jessie Berlin

Comment 11 2011-06-24 14:12:07 PDT

Removing the MakingBotsRed keyword as this isn't actively making any bots red.

Note You need to log in before you can comment on or make changes to this bug.