Summary: | DumpRenderTree on Windows doesn't block access to external URLs, but should (makes some tests fail) | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | NEW --- | ||||||
Severity: | Normal | CC: | jberlin, mjs, zimmermann | ||||
Priority: | P2 | Keywords: | InRadar, LayoutTestFailure, PlatformOnly | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows 7 | ||||||
URL: | http://build.webkit.org/results/Windows%207%20Release%20%28Tests%29/r82237%20(10912)/http/tests/uri/username-with-no-hostname-pretty-diff.html | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-03-29 07:02:18 PDT
The test is failing because DRT/win's ResourceLoadDelegate doesn't have the "block access to external URLs" logic that DRT/mac has. That logic was added to DRT/mac in r33491. Created attachment 87335 [details]
Patch to add "block access to external URLs" logic to DRT/win
This patch gives DRT/win the same smarts as DRT/mac. However, this causes the test to fail in a different way: the "Blocked access to external URL" message is printed twice (once for the real load, and once for a preload). I don't know why this doesn't happen on Mac.
I checked in new expected results for Windows in r82255. This bug can be used to track the task of adding the URL-blocking logic to DRT. I think the new expected results for Windows broke WK2 Windows tests: http://build.webkit.org/results/Windows%207%20Release%20(WebKit2%20Tests)/r82253%20(4654)/results.html http://build.webkit.org/results/Windows%207%20Release%20(WebKit2%20Tests)/r82255%20(4655)/results.html You're right! I'll take care of it. (In reply to comment #2) > Created an attachment (id=87335) [details] > Patch to add "block access to external URLs" logic to DRT/win > > This patch gives DRT/win the same smarts as DRT/mac. However, this causes the test to fail in a different way: the "Blocked access to external URL" message is printed twice (once for the real load, and once for a preload). I don't know why this doesn't happen on Mac. Ooh, it happened once on Mac! http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r82463%20(10201)/http/tests/uri/username-with-no-hostname-pretty-diff.html *** Bug 58421 has been marked as a duplicate of this bug. *** Added more win-wk2 passing results in http://trac.webkit.org/changeset/83989 Removing the MakingBotsRed keyword as this isn't actively making any bots red. |