Bug 57324
| Summary: | [Qt] Refactor buildQMakeProject() in webkitdirs.pm | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Csaba Osztrogonác <ossy> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | abecsi, jturcotte, kbalazs, laszlo.gombos, loki, ossy, zoltan |
| Priority: | P3 | Keywords: | Qt, QtTriaged |
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | All | ||
Csaba Osztrogonác
Now buildQMakeProject() in webkitdirs.pm is so ugly and hardly
understandable. We should make it simple, structured, etc.
I opened this bug for discussion about how to start. :)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Zoltan Horvath
Is it? What would you like to achieve? ;)
Balazs Kelemen
(In reply to comment #1)
> Is it? What would you like to achieve? ;)
I have tested it (by picking Gabor's build-jsc patch to my 1.5 year old branch).
Yes, it is definitely spaghetti.
Csaba Osztrogonác
It was refactored in another bug in other way.