Summary: | Web Inspector: document Timeline domain, make timeline event types of type string. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, apavlov, buildbot, bweinstein, dglazkov, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit-ews, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pavel Feldman
2011-03-28 22:28:40 PDT
Created attachment 87262 [details]
Patch
Attachment 87262 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8281066 Attachment 87262 [details] did not build on qt: Build output: http://queues.webkit.org/results/8280068 Attachment 87262 [details] did not build on win: Build output: http://queues.webkit.org/results/8285071 Created attachment 87264 [details]
[PATCH] Patch that compiles.
Comment on attachment 87264 [details] [PATCH] Patch that compiles. View in context: https://bugs.webkit.org/attachment.cgi?id=87264&action=review > Source/WebCore/inspector/InspectorTimelineAgent.cpp:54 > +static const char EventDispatch[] = "EventDispatch"; Could we sort them alphabetically. > Source/WebCore/inspector/front-end/TimelineAgent.js:37 > + EventDispatch: "EventDispatch", We should enumerated these constants in the .json scheme. This deserves its own change, please file a bug and put a FIXME here. Committed r82239: <http://trac.webkit.org/changeset/82239> http://trac.webkit.org/changeset/82239 might have broken Qt Linux Release minimal |