Bug 57232

Summary: Change default alignment for LI elements to -webkit-match-parent
Product: WebKit Reporter: Jeremy Moskovich <playmobil>
Component: New BugsAssignee: Jeremy Moskovich <playmobil>
Status: RESOLVED FIXED    
Severity: Normal CC: aharon, eric, mitz, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Jeremy Moskovich
Reported 2011-03-28 07:42:30 PDT
Change default alignment for LI elements to -webkit-match-parent
Attachments
Patch (5.44 KB, patch)
2011-03-28 07:48 PDT, Jeremy Moskovich 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jeremy Moskovich
Comment 1 2011-03-28 07:48:07 PDT
Created attachment 87143 [details] Patch
Eric Seidel (no email)
Comment 2 2011-03-28 07:54:11 PDT
Comment on attachment 87143 [details] Patch LGTM. I assume other browsers don't pass this yet?
Eric Seidel (no email)
Comment 3 2011-03-28 07:55:19 PDT
Would be nice if your ChangeLog could give more justification for this change. (Like citations of the spec, or the style mailing list.) Has this changed in HTML5? If not, will you please file a bug against the HTML5 spec and reference it form this bug (and ideally your ChangeLog).
Aharon (Vladimir) Lanin
Comment 4 2011-03-29 03:30:59 PDT
(In reply to comment #3) > Would be nice if your ChangeLog could give more justification for this change. (Like citations of the spec, or the style mailing list.) > > Has this changed in HTML5? If not, will you please file a bug against the HTML5 spec and reference it form this bug (and ideally your ChangeLog). This has been discussed on the CSS list, see http://lists.w3.org/Archives/Public/www-style/2011Feb/0066.html and keep going in the thread. It includes the status vis-a-vis the HTML5 spec.
Jeremy Moskovich
Comment 5 2011-03-29 06:40:32 PDT
HTML5 bug: http://www.w3.org/Bugs/Public/show_bug.cgi?id=10824
Ryosuke Niwa
Comment 6 2011-04-03 00:13:12 PDT
Has this been landed or not?
Ryosuke Niwa
Comment 7 2011-06-18 10:21:01 PDT
Jeremy, have you landed this patch yet?
WebKit Review Bot
Comment 8 2011-06-18 12:52:47 PDT
Comment on attachment 87143 [details] Patch Clearing flags on attachment: 87143 Committed r89199: <http://trac.webkit.org/changeset/89199>
WebKit Review Bot
Comment 9 2011-06-18 12:52:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.