Bug 57222

Summary: [EFL] Remove unnecessary ewk_view_viewport_attributes_set() invocation
Product: WebKit Reporter: Gyuyoung Kim <gyuyoung.kim>
Component: WebKit EFLAssignee: Gyuyoung Kim <gyuyoung.kim>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kenneth, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Proposed Patch none

Gyuyoung Kim
Reported 2011-03-28 03:59:40 PDT
Now, FrameLoaderClientEfl::dispatchDidCommitLoad() invokes ewk_view_viewport_attributes_set() unconditionally. When WebCore didn't support to switch between mobile page and desktop page, we needed to send dummy viewport signal to application in order to set viewport for desktop width. (as soon as page starts to load.) But, latest WebCore sends viewport signal whenever viewport is changed by Page::updateViewportArguments(). Thus, IMO, we don't need to call ewk_view_viewport_attributes_set() with dummy viewport data anymore.
Attachments
Proposed Patch (1.64 KB, patch)
2011-03-28 04:06 PDT, Gyuyoung Kim 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1 2011-03-28 04:06:07 PDT
Created attachment 87122 [details] Proposed Patch
WebKit Commit Bot
Comment 2 2011-03-29 00:31:13 PDT
Comment on attachment 87122 [details] Proposed Patch Clearing flags on attachment: 87122 Committed r82205: <http://trac.webkit.org/changeset/82205>
WebKit Commit Bot
Comment 3 2011-03-29 00:31:17 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.