Bug 57196

Summary: Fix script-src redirect handling
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 53572    
Attachments:
Description Flags
Patch eric: review+

Adam Barth
Reported 2011-03-27 17:00:54 PDT
Fix script-src redirect handling
Attachments
Patch (9.68 KB, patch)
2011-03-27 17:08 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-03-27 17:08:21 PDT
Created attachment 87091 [details] Patch
Eric Seidel (no email)
Comment 2 2011-03-27 20:51:30 PDT
Comment on attachment 87091 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=87091&action=review Seems reasonable. > Source/WebCore/loader/cache/CachedResourceLoader.cpp:261 > default: default: is always sub-optimal when dealing with enums. How many would it be to list out the rest and have them all break?
Adam Barth
Comment 3 2011-03-27 21:02:31 PDT
(In reply to comment #2) > (From update of attachment 87091 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=87091&action=review > > Seems reasonable. > > > Source/WebCore/loader/cache/CachedResourceLoader.cpp:261 > > default: > > default: is always sub-optimal when dealing with enums. How many would it be to list out the rest and have them all break? It wouldn't be that hard. I removed a bunch of defaults from the rest of this function in this patch. I'm inclined to leave it or change it to an if. Maybe an if would be best actually...
Adam Barth
Comment 4 2011-03-27 22:16:02 PDT
Committed r82085: <http://trac.webkit.org/changeset/82085>
Note You need to log in before you can comment on or make changes to this bug.