Summary: | InlineBox::prevOnline and InlineBox::prevOnlineExists() are confusing and should be renamed | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> | ||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED WONTFIX | ||||||
Severity: | Normal | CC: | ahmad.saleem792, commit-queue, hyatt, mitz, rniwa, simon.fraser, xji, yael, zalan | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Eric Seidel (no email)
2011-03-27 04:03:33 PDT
This came up when Yael and I were looking at fixing bug 9272. After http://trac.webkit.org/changeset/82419, prevOnLineExists() and nextOnLineExists() are no longer used. I am preparing a patch to remove them, and all the flags associated with them. Created attachment 89063 [details]
Patch.
Remove nextOnLineExists() and prevOnLineExists(), as they are not used anymore.
Comment on attachment 89063 [details]
Patch.
OK. Sounds great. Thanks!
Comment on attachment 89063 [details] Patch. Clearing flags on attachment: 89063 Committed r83515: <http://trac.webkit.org/changeset/83515> All reviewed patches have been landed. Closing bug. This broke GTK builds. They were apparently used in AccessibilityObjectWrapperAtk.cpp: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/21347/steps/compile-webkit/logs/stdio Wow, that's so wrong it hurts. Committed r83540: <http://trac.webkit.org/changeset/83540> Sorry, I had to roll out the patch in http://trac.webkit.org/changeset/83540 because there wasn't obvious alternatives to call. (In reply to comment #10) > Sorry, I had to roll out the patch in http://trac.webkit.org/changeset/83540 because there wasn't obvious alternatives to call. Thank you for rolling out. Sorry I was not online to see that it broke the build. Do we need to track this? This is in Legacy Line Layout. Only following references exists in our code besides in 'LegacyInlineBox.cpp/h': In RenderLineBreak: isLastOnLine = !containingBlock->containingBlock()->inlineBoxWrapper()->nextOnLineExists(); isLastOnLine = !containingBlock->inlineBoxWrapper()->nextOnLineExists(); In RenderText: isLastOnLine = !containingBlock->containingBlock()->inlineBoxWrapper()->nextOnLineExists(); isLastOnLine = !containingBlock->inlineBoxWrapper()->nextOnLineExists(); (In reply to Ahmad Saleem from comment #12) > Do we need to track this? Certainly not. This code is soon to be completely removed. |