Bug 57171
| Summary: | check-webkit-style errors on trailing comma replaced by space when comments follow | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ben Taylor <bentaylor.solx86> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | levin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Other | ||
Ben Taylor
The example patch failed the check-webkit-style, and I believe this to be a false positive:
The , that is replaced should be acceptable to be replaced by a space " " so that
trailing comments maintain their 'style"
Index: Source/WebCore/platform/network/ResourceRequestBase.h
===================================================================
--- Source/WebCore/platform/network/ResourceRequestBase.h (revision 82026)
+++ Source/WebCore/platform/network/ResourceRequestBase.h (working copy)
@@ -41,7 +41,7 @@ namespace WebCore {
UseProtocolCachePolicy, // normal load
ReloadIgnoringCacheData, // reload
ReturnCacheDataElseLoad, // back/forward or encoding change - allow stale data
- ReturnCacheDataDontLoad, // results of a post - allow stale data and only use cache
+ ReturnCacheDataDontLoad // results of a post - allow stale data and only use cache
};
class ResourceRequest;
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Levin
Somehow I missed this in my previous search.
Regardless this has been discussed before, and it is not desirable in this project:
https://lists.webkit.org/pipermail/webkit-dev/2009-September/009814.html