Bug 57153 – Add support for aligned buffers without alignment macros

• Component: JavaScriptCore
• Status: RESOLVED INVALID

[Ben Taylor]

Solaris 10 with Sun Studio 12 CC does not have alignment macros. We need a way to work around this issue.

[Ben Taylor]

Created attachment 87027 [details]
Proposed patch which compiles correctly in qt-4.7.1 with webkit enabled on Solaris 10 with SS12 C++ compiler

This is the first patch against JavaScriptCore/wtf/Vector.h to support aligned buffers
without alignement macros.  This is patch 2 of 17 original submitted by Thiago Macieria
in bug https://bugs.webkit.org/show_bug.cgi?id=24932. Once this patch is commited, the
second fix to deal with alignment of the buffers can be submitted.  This compiles on
Solaris 10/Sun Studio 12 CC, but the patch is against webkit head.

[WebKit Review Bot]

Attachment 87027 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/Vector.h:70:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ben Taylor]

Created attachment 87028 [details]
Updated patch which should pass the check-webkit-style bot

Updated patch to pass check-webkit-style bot.

[WebKit Review Bot]

Comment on attachment 87028 [details]
Updated patch which should pass the check-webkit-style bot

Rejecting attachment 87028 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Attachment 87028 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/wtf/Vector.h:70:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ben Taylor]

Created attachment 87044 [details]
Updated patch which should really pass the check-webkit-style bot

Fixed really this time.

[Eric Seidel (no email)]

I'm not sure who should review this.

[Ben Taylor]

(In reply to comment #7)
> I'm not sure who should review this.

The original comment from Thiago Macieria for this patch was:

If we don't have alignment macros, we do what we can:
overcommit 64 bytes and find the proper 64-byte-aligned position in
the buffer.

If preferred, I can do this as a single patch with both the add of support
for buffer alignment without alignment macros, and the fix for oversized-buffer
support for aligning.

[Ben Taylor]

I talked with Thiago regarding this patch.  He seems to think that Solaris has alignment macros, so we should probably use those instead of this patch.  I'd like to cancel this patch.

[Eric Seidel (no email)]

OK.  Closing.

[Eric Seidel (no email)]

Comment on attachment 87044 [details]
Updated patch which should really pass the check-webkit-style bot

Cleared review? from attachment 87044 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).