| Summary: | [Qt] Change TextureMapperVideoLayer to TextureMapperMediaLayer | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Kwang Yul Seo <skyul> | ||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, commit-queue, noam | ||||||
| Priority: | P4 | Keywords: | Qt, QtTriaged | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Kwang Yul Seo
2011-03-25 23:29:01 PDT
Created attachment 87012 [details]
Patch
Comment on attachment 87012 [details]
Patch
Stricto sensu, the media content type is video or composited plugin. For me, it looks like the real fix is to change TextureMapperVideoLayer to a TextureMapperMediaLayer where plugins are supported. Alternatively, add a new type for Plugin.
No'am, any comment?
Created attachment 87119 [details]
Patch
Comment on attachment 87119 [details]
Patch
The changes in /texmap/ look correct to me.
The change in the Qt implementation does not because of this:
class TextureMapperVideoLayerQt : public virtual TextureMapperMediaLayer
-> the Qt layer is limited to video.
I still r+ because this is improving texture mapper and fixing the Qt layer is a separate problem. But please open a new bug for having a correct implementation of TextureMapperMediaLayer for Qt.
The commit-queue encountered the following flaky tests while processing attachment 87119 [details]: fast/workers/storage/use-same-database-in-page-and-workers.html bug 50995 (author: dumi@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 87119 [details] Patch Clearing flags on attachment: 87119 Committed r82199: <http://trac.webkit.org/changeset/82199> All reviewed patches have been landed. Closing bug. |