Bug 5711

Summary:

Remove APPLE_CHANGES blocks and unused code from khtml

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

WebKit Misc.

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
patch removing APPLE_CHANGES	mjs: review+
cleanup script	none
A hacked version of the partial preprocessor	none
A better hacked version of partpp.pl	none

Description Eric Seidel (no email) 2005-11-11 11:35:09 PST

We've forked from khtml... let's admit that to ourselves.

I think it's time to clean up the code and remove all the APPLE_CHANGES defines and blocks from khtml.

I've attached a patch which does just that, as well as the scripts I used to make this happen.

Comment 1 Eric Seidel (no email) 2005-11-11 11:36:10 PST

Created attachment 4667 [details]
patch removing APPLE_CHANGES

Comment 2 Eric Seidel (no email) 2005-11-11 11:36:48 PST

Created attachment 4668 [details]
cleanup script

Comment 3 Eric Seidel (no email) 2005-11-11 11:37:14 PST

Created attachment 4669 [details]
A hacked version of the partial preprocessor

Comment 4 Eric Seidel (no email) 2005-11-11 11:37:58 PST

Comment on attachment 4667 [details]
patch removing APPLE_CHANGES

This patch removes all mention of APPLE_CHANGES from khtml, as well as removes
unused #if 0 blocks.

Comment 5 Maciej Stachowiak 2005-11-11 18:42:54 PST

r=me assuming the results build and pass tests

Comment 6 Eric Seidel (no email) 2005-11-20 17:17:33 PST

Created attachment 4751 [details]
A better hacked version of partpp.pl