Bug 5711

Summary:

Remove APPLE_CHANGES blocks and unused code from khtml

Product:

WebKit

Reporter:

Eric Seidel (no email) <eric>

Component:

WebKit Misc.

Assignee:

Eric Seidel (no email) <eric>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
patch removing APPLE_CHANGES	mjs: review+
cleanup script	none
A hacked version of the partial preprocessor	none
A better hacked version of partpp.pl	none

Eric Seidel (no email)

Reported 2005-11-11 11:35:09 PST

We've forked from khtml... let's admit that to ourselves. I think it's time to clean up the code and remove all the APPLE_CHANGES defines and blocks from khtml. I've attached a patch which does just that, as well as the scripts I used to make this happen.

Attachments
patch removing APPLE_CHANGES (413.06 KB, patch) 2005-11-11 11:36 PST, Eric Seidel (no email)	mjs: review+	Details Formatted Diff Diff
cleanup script (351 bytes, text/x-perl-script) 2005-11-11 11:36 PST, Eric Seidel (no email)	no flags	Details
A hacked version of the partial preprocessor (17.53 KB, text/x-perl-script) 2005-11-11 11:37 PST, Eric Seidel (no email)	no flags	Details
A better hacked version of partpp.pl (17.54 KB, text/x-perl-script) 2005-11-20 17:17 PST, Eric Seidel (no email)	no flags	Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Eric Seidel (no email)

Comment 1 2005-11-11 11:36:10 PST

Created attachment 4667 [details] patch removing APPLE_CHANGES

Eric Seidel (no email)

Comment 2 2005-11-11 11:36:48 PST

Created attachment 4668 [details] cleanup script

Eric Seidel (no email)

Comment 3 2005-11-11 11:37:14 PST

Created attachment 4669 [details] A hacked version of the partial preprocessor

Eric Seidel (no email)

Comment 4 2005-11-11 11:37:58 PST

Comment on attachment 4667 [details] patch removing APPLE_CHANGES This patch removes all mention of APPLE_CHANGES from khtml, as well as removes unused #if 0 blocks.

Maciej Stachowiak

Comment 5 2005-11-11 18:42:54 PST

r=me assuming the results build and pass tests

Eric Seidel (no email)

Comment 6 2005-11-20 17:17:33 PST

Created attachment 4751 [details] A better hacked version of partpp.pl

Note You need to log in before you can comment on or make changes to this bug.