Bug 57097

Summary:

[Chromium] Add CGBitmapContext.h include to WebViewImpl.cpp

Product:

WebKit

Reporter:

Cary Clark <caryclark>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.5

Attachments:

Description	Flags
patch to add include	dglazkov: review-
patch with correctly generated ChangeLog	none

Cary Clark

Reported 2011-03-25 05:54:28 PDT

In the Chrome tree, removing '#import ApplicationServices.h' from skia/ext/platform_device_mac.h avoids header conflicts, but causes WebKit/chromium/src/WebViewImpl.cpp to fail, since it refers to CGBitmapContextGetHeight(). Adding #include CGBitmapContext.h to WebViewImpl.cpp fixes this.

Attachments
patch to add include (1.02 KB, patch) 2011-03-25 07:57 PDT, Cary Clark	dglazkov: review-	Details Formatted Diff Diff
patch with correctly generated ChangeLog (1006 bytes, patch) 2011-03-25 11:26 PDT, Cary Clark	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Cary Clark

Comment 1 2011-03-25 07:57:11 PDT

Created attachment 86939 [details] patch to add include

Cary Clark

Comment 2 2011-03-25 07:59:10 PDT

This patch is in support of http://codereview.chromium.org/6732027/

Dimitri Glazkov (Google)

Comment 3 2011-03-25 08:48:29 PDT

Comment on attachment 86939 [details] patch to add include View in context: https://bugs.webkit.org/attachment.cgi?id=86939&action=review seems easy-peasy enough :) But the ChangeLog needs to tweakage. > Source/WebKit/chromium/ChangeLog:3 > + Reviewed by ? Please leave this line alone. It should say OOPS, that's being used by webkit-patch for landing.

Cary Clark

Comment 4 2011-03-25 11:26:24 PDT

Created attachment 86962 [details] patch with correctly generated ChangeLog

Dimitri Glazkov (Google)

Comment 5 2011-03-25 11:28:22 PDT

Comment on attachment 86962 [details] patch with correctly generated ChangeLog great! Also useful is the --request-commit flag in the webkit-patch. It allows you to request the patch to be landed by a commit-queue.

WebKit Commit Bot

Comment 6 2011-03-25 12:12:45 PDT

Comment on attachment 86962 [details] patch with correctly generated ChangeLog Clearing flags on attachment: 86962 Committed r81979: <http://trac.webkit.org/changeset/81979>

WebKit Commit Bot

Comment 7 2011-03-25 12:12:50 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.