Summary: | [Qt][Symbian] Fix Api test failure -- tst_QWebView::focusInputTypes | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yi Shen <max.hong.shen> | ||||||
Component: | WebKit Qt | Assignee: | Yi Shen <max.hong.shen> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ademar, commit-queue, laszlo.gombos, menard | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | S60 Hardware | ||||||||
OS: | Other | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 50925 | ||||||||
Attachments: |
|
Description
Yi Shen
2011-03-24 08:49:23 PDT
Created attachment 86780 [details]
first try
Comment on attachment 86780 [details] first try View in context: https://bugs.webkit.org/attachment.cgi?id=86780&action=review > Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:34 > +#ifdef Q_OS_SYMBIAN This also counts for other platforms like MAEMO etc. Please verify and fix as well (In reply to comment #2) > (From update of attachment 86780 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86780&action=review > > > Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:34 > > +#ifdef Q_OS_SYMBIAN > > This also counts for other platforms like MAEMO etc. Please verify and fix as well Hi Kenneth, I am agree with you that MAEMO may have the same issue, and I would suggest to create a separate bug to test/fix the issue. Again, thanks for the review :) Comment on attachment 86780 [details] first try View in context: https://bugs.webkit.org/attachment.cgi?id=86780&action=review >>> Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:34 >>> +#ifdef Q_OS_SYMBIAN >> >> This also counts for other platforms like MAEMO etc. Please verify and fix as well > > Hi Kenneth, I am agree with you that MAEMO may have the same issue, and I would suggest to create a separate bug to test/fix the issue. Again, thanks for the review :) Can you test it? > Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:319 > +#if defined(Q_WS_MAEMO_5) || defined(Q_WS_MAEMO_6) || defined(Q_OS_SYMBIAN) Why here #if defined(Q_WS_MAEMO_5) || defined(Q_WS_MAEMO_6) if your patch doesn't actually covers Maemo? (In reply to comment #4) > (From update of attachment 86780 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86780&action=review > > >>> Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:34 > >>> +#ifdef Q_OS_SYMBIAN > >> > >> This also counts for other platforms like MAEMO etc. Please verify and fix as well > > > > Hi Kenneth, I am agree with you that MAEMO may have the same issue, and I would suggest to create a separate bug to test/fix the issue. Again, thanks for the review :) > > Can you test it? Thanks for your input, Alexis. Unfortunately, I don't have a meego/maemo env at hand to test it. So I created a bug for the same issue on meego/maemo (https://bugs.webkit.org/show_bug.cgi?id=57485), and will look at it when I got a chance.(Or someone has meego env can make a quick patch for it) > > > Source/WebKit/qt/tests/qwebview/tst_qwebview.cpp:319 > > +#if defined(Q_WS_MAEMO_5) || defined(Q_WS_MAEMO_6) || defined(Q_OS_SYMBIAN) > > Why here #if defined(Q_WS_MAEMO_5) || defined(Q_WS_MAEMO_6) if your patch doesn't actually covers Maemo? I am going to remove the Maemo tag from this patch Created attachment 87595 [details]
remove maemo macro
Comment on attachment 87595 [details]
remove maemo macro
LGTM
Comment on attachment 87595 [details] remove maemo macro Clearing flags on attachment: 87595 Committed r82517: <http://trac.webkit.org/changeset/82517> All reviewed patches have been landed. Closing bug. |