Bug 57010

Summary: Web Inspector: fix console messages positions in formatted scripts.
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch. yurys: review+

Description Pavel Podivilov 2011-03-24 06:38:49 PDT 
Web Inspector: fix console messages positions in formatted scripts.
Comment 1 Pavel Podivilov 2011-03-24 06:39:26 PDT 
Created attachment 86766 [details]
Patch.
Comment 2 Yury Semikhatsky 2011-03-24 07:22:08 PDT 
Comment on attachment 86766 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=86766&action=review

> Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:187
> +            presentationMessage.sourceFileId = sourceFile.id;

Would be nice to see sourceFile declaration above didRequestMapping
Comment 3 Pavel Podivilov 2011-03-28 05:23:44 PDT 
Committed r82107: <http://trac.webkit.org/changeset/82107>
Comment 4 Pavel Podivilov 2011-03-28 05:24:08 PDT 
(In reply to comment #2)
> (From update of attachment 86766 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86766&action=review
> 
> > Source/WebCore/inspector/front-end/DebuggerPresentationModel.js:187
> > +            presentationMessage.sourceFileId = sourceFile.id;
> 
> Would be nice to see sourceFile declaration above didRequestMapping

Done.