Bug 56980

Summary: web audio: Properly sample-rate convert audio assets in chromium port
Product: WebKit Reporter: Chris Rogers <crogers>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Rogers
Reported 2011-03-23 17:44:01 PDT
web audio: Properly sample-rate convert audio assets in chromium port
Attachments
Patch (9.49 KB, patch)
2011-03-23 17:54 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (10.74 KB, patch)
2011-03-24 14:13 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (10.76 KB, patch)
2011-03-24 16:19 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2011-03-23 17:54:59 PDT
Created attachment 86727 [details] Patch
Chris Rogers
Comment 2 2011-03-23 18:12:19 PDT
In looking over this again, I see that it would be more efficient to mix-to-mono first, before sample-rate converting. I'll upload a new patch changing that part, but the other parts can still be reviewed...
Chris Rogers
Comment 3 2011-03-23 18:20:46 PDT
I also need to conditionally compile AudioBus::createBySampleRateConverting for chromium-only, or provide an implementation for the mac-port as well. It's not actually needed for the mac port, so will probably conditionally compile.
Kenneth Russell
Comment 4 2011-03-23 19:43:22 PDT
Comment on attachment 86727 [details] Patch Looks fine to me. Why don't you upload the final version of the patch and I'll r+ that.
Chris Rogers
Comment 5 2011-03-24 14:13:14 PDT
Created attachment 86835 [details] Patch
Chris Rogers
Comment 6 2011-03-24 14:15:06 PDT
AudioBus::createBySampleRateConverting() is now not compiled in for the mac port, since it's not needed there. I added #if ENABLE(WEB_AUDIO) to SincResampler which was missing it before. For efficiency, the resampling now first mixes down to mono (if necessary)
Kenneth Russell
Comment 7 2011-03-24 16:15:34 PDT
Looks good. r=me
Chris Rogers
Comment 8 2011-03-24 16:19:08 PDT
Created attachment 86853 [details] Patch
Chris Rogers
Comment 9 2011-03-24 16:20:54 PDT
Sorry, Ken I just uploaded another patch with a very minor change to conditionally include: #if !PLATFORM(MAC) #include "SincResampler.h" #endif
Kenneth Russell
Comment 10 2011-03-24 16:50:18 PDT
Comment on attachment 86853 [details] Patch OK.
WebKit Commit Bot
Comment 11 2011-03-24 19:13:52 PDT
Comment on attachment 86853 [details] Patch Clearing flags on attachment: 86853 Committed r81931: <http://trac.webkit.org/changeset/81931>
WebKit Commit Bot
Comment 12 2011-03-24 19:13:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.