Bug 56957

Summary: WebKit2: Flashing when entering and exiting full screen mode
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: WebKit2Assignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: aroben, commit-queue
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: All   
Attachments:
Description Flags
Patch none

Jer Noble
Reported 2011-03-23 13:19:42 PDT
When the full screen animation completes, the full screen window flashes before setting the full screen element's background color to black.
Attachments
Patch (9.89 KB, patch)
2011-05-18 01:55 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2011-03-23 13:20:00 PDT
<rdar://problem/9177012>
Jer Noble
Comment 2 2011-05-18 01:55:38 PDT
Created attachment 93885 [details] Patch
Adam Roben (:aroben)
Comment 3 2011-05-18 10:56:31 PDT
Do we need to do something similar on Windows?
Jer Noble
Comment 4 2011-05-18 11:09:09 PDT
(In reply to comment #3) > Do we need to do something similar on Windows? Yes. We should probably wait for a repaint to complete before beginning the "fade in" animation.
Maciej Stachowiak
Comment 5 2011-05-19 13:11:05 PDT
Comment on attachment 93885 [details] Patch r=me
WebKit Commit Bot
Comment 6 2011-05-19 22:31:19 PDT
Comment on attachment 93885 [details] Patch Clearing flags on attachment: 93885 Committed r86924: <http://trac.webkit.org/changeset/86924>
WebKit Commit Bot
Comment 7 2011-05-19 22:31:24 PDT
All reviewed patches have been landed. Closing bug.
Adam Roben (:aroben)
Comment 8 2011-05-20 05:36:44 PDT
(In reply to comment #4) > (In reply to comment #3) > > Do we need to do something similar on Windows? > > Yes. We should probably wait for a repaint to complete before beginning the "fade in" animation. Do we have a bug for Windows?
Jer Noble
Comment 9 2011-05-20 06:36:17 PDT
(In reply to comment #8) > Do we have a bug for Windows? We do: https://bugs.webkit.org/show_bug.cgi?id=61108
Note You need to log in before you can comment on or make changes to this bug.