Bug 56948 – Tabbing from the last focused field to a non-webpage element leaves the selection in a weird state

• Component: WebKit2
• Status: RESOLVED FIXED

[Jon Lee]

Go to http://gcc.gnu.org/onlinedocs/

Select some text.

Press tab, option-l, or click in the location bar to remove focus from the web view and into the location bar

The selection remains instead of being cleared.

[Jon Lee]

<rdar://problem/8553962>

[Jon Lee]

Created attachment 86724 [details]
Patch

[Sam Weinig]

Comment on attachment 86724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86724&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1129
> +    FocusController* focusController = m_page->focusController();

Before this line, you should add RefPtr<WebPage> protect(this);  There is also no need for this local variable.

[Jon Lee]

Created attachment 86791 [details]
Refactored local variable

[Darin Adler]

Comment on attachment 86791 [details]
Refactored local variable

View in context: https://bugs.webkit.org/attachment.cgi?id=86791&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1130
> +    if (!isFocused)
> +        m_page->focusController()->focusedOrMainFrame()->selection()->clear();

Sam said: “Before this line, you should add RefPtr<WebPage> protect(this)”.

[Darin Adler]

Comment on attachment 86791 [details]
Refactored local variable

John told me that adding the RefPtr is more challenging than it looks, so we’ll do that in a separate patch after we land this fix.

[Darin Adler]

(In reply to comment #6)
> John told me that adding the RefPtr is more challenging than it looks, so we’ll do that in a separate patch after we land this fix.

No, Jon told me that!

[WebKit Commit Bot]

Comment on attachment 86791 [details]
Refactored local variable

Clearing flags on attachment: 86791

Committed r81880: <http://trac.webkit.org/changeset/81880>