Summary: | [Qt][Symbian] Fix Api test failure -- tst_QWebFrame::setHtmlWithBaseURL | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yi Shen <max.hong.shen> | ||||||||||
Component: | WebKit Qt | Assignee: | Yi Shen <max.hong.shen> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ademar, commit-queue, laszlo.gombos, menard, s.mathur | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | S60 Hardware | ||||||||||||
OS: | Other | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 38654, 50925 | ||||||||||||
Attachments: |
|
Description
Yi Shen
2011-03-23 12:11:21 PDT
Created attachment 86661 [details]
first try
Created attachment 86772 [details]
proposed fix
Comment on attachment 86772 [details]
proposed fix
Why dont other platforms need this?
(In reply to comment #3) > (From update of attachment 86772 [details]) > Why dont other platforms need this? For desktop env like Linux, Windows, they don't need this. For other mobile env like Meego, Maemo, they may need to add a similar, platform-dependent patch. It would be good to be done in a separated bug. Thanks! (In reply to comment #2) > Created an attachment (id=86772) [details] > proposed fix If the .png and other content can be loaded from a qrc:// URL as part of the test, then we should prefer that. I.e add to qmake's RESOURCES list. If the test requires loading a file from local disk, then we should install the .png within c:\private\UID3ofTestRunnerEXE\ , and not in C:\resource Created attachment 88258 [details]
updated with Siddharth's suggestion
Created attachment 88261 [details]
fix the changlog
Comment on attachment 88261 [details]
fix the changlog
lgtm
Comment on attachment 88261 [details] fix the changlog Clearing flags on attachment: 88261 Committed r84974: <http://trac.webkit.org/changeset/84974> All reviewed patches have been landed. Closing bug. |