Summary: | [Qt] Fix Api tests for QWebPage on symbian | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Yi Shen <max.hong.shen> | ||||||||||
Component: | WebKit Qt | Assignee: | Yi Shen <max.hong.shen> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | ademar, commit-queue, laszlo.gombos, menard | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | S60 Hardware | ||||||||||||
OS: | Other | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 50925 | ||||||||||||
Attachments: |
|
Description
Yi Shen
2011-03-23 07:55:40 PDT
Created attachment 86620 [details]
first try
Comment on attachment 86620 [details] first try View in context: https://bugs.webkit.org/attachment.cgi?id=86620&action=review A quick look tells me that the html code used as reference is the same except for the font-family. Could you use instead QString::arg and specify a different arg for either Symbian or other platforms? I'm wondering also if you could get the current font used so that we don't need to add ifdef at all. > Source/WebKit/qt/ChangeLog:8 > + Modified test case to use font 'NOkia Sans S60' on Symbian. Typo :D I believe it's Nokia not NOkia. Created attachment 87599 [details]
updated with Alexis's suggestion
Comment on attachment 87599 [details]
updated with Alexis's suggestion
Great so much better, need a r+ from a reviewer now :D
Comment on attachment 87599 [details]
updated with Alexis's suggestion
I do not think autotests should be sensitive to platform fonts. I would rather modify the tests so that it simply ignores the style.
For font-sensitive tests we should use LayoutTests which has a mechanism of platform dependent expected results.
Yi, can you change the test so that it ignores the style that selectedHtml() returns ?
Created attachment 89855 [details]
ignores the style
Created attachment 90063 [details]
fix the regular expression
Comment on attachment 90063 [details]
fix the regular expression
r=me. Thanks.
Comment on attachment 90063 [details] fix the regular expression Clearing flags on attachment: 90063 Committed r84171: <http://trac.webkit.org/changeset/84171> All reviewed patches have been landed. Closing bug. |