Bug 56919

Summary:

Web Inspector: remove unnecessary reinterpret_cast in XMLTreeViewer

Product:

WebKit

Reporter:

Yury Semikhatsky <yurys>

Component:

Web Inspector (Deprecated)

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, apavlov, aroben, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	pfeldman: review+

Yury Semikhatsky

Reported 2011-03-23 05:49:17 PDT

Web Inspector: remove unnecessary reinterpret_cast in XMLTreeViewer. This is a follow-up to 56843.

Attachments
Patch (1.92 KB, patch) 2011-03-23 05:51 PDT, Yury Semikhatsky	pfeldman: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Yury Semikhatsky

Comment 1 2011-03-23 05:51:35 PDT

Yury Semikhatsky

Comment 2 2011-03-23 05:57:27 PDT

Adam Roben (:aroben)

Comment 3 2011-03-23 06:24:11 PDT

Looks like this broke the Windows build: 3>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\obj\WebCore\DerivedSources\XMLViewerXSL.h(2) : warning C4309: 'initializing' : truncation of constant value http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/13616/steps/compile-webkit/logs/stdio

WebKit Review Bot

Comment 4 2011-03-23 06:26:03 PDT

http://trac.webkit.org/changeset/81768 might have broken Windows Release (Build) and Windows Debug (Build)

Yury Semikhatsky

Comment 5 2011-03-23 06:28:57 PDT

Rolled out in r81770

Note You need to log in before you can comment on or make changes to this bug.