Bug 56892

Summary: Adding floats to an empty block is O(n^2)
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch mitz: review+

Dave Hyatt
Reported 2011-03-22 20:06:53 PDT
If you just add floats back to back to an empty block, the addition is essentially O(n^2) once the floats move below your current line position. This is because we repeatedly ask for the available width for the line from scratch every time we add a float, regardless of whether the float even vertically intersected our current line position.
Attachments
Patch (8.09 KB, patch)
2011-03-22 20:09 PDT, Dave Hyatt 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2011-03-22 20:09:49 PDT
Created attachment 86563 [details] Patch
mitz
Comment 2 2011-03-22 20:15:45 PDT
Comment on attachment 86563 [details] Patch I assume all tests pass :-)
Dave Hyatt
Comment 3 2011-03-22 20:27:27 PDT
Fixed in r81746.
Note You need to log in before you can comment on or make changes to this bug.