Bug 56884 – Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory

• Component: New Bugs
• Status: RESOLVED FIXED

[Adam Klein]

Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory

[Adam Klein]

Created attachment 86550 [details]
Patch

[Mihai Parparita]

Comment on attachment 86550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86550&action=review

> Tools/ChangeLog:9
> +        referencing js-test-resources from a layout test over HTTP.

I'm not entirely sure I understand the use-case here, but if you'd like to remap what directories are available at what location when using new-run-webkit-tests's HTTP server, you can use aliases the way http://trac.webkit.org/changeset/79630 works (see the Tools/Scripts changes).

[Adam Klein]

Comment on attachment 86550 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86550&action=review

>> Tools/ChangeLog:9
>> +        referencing js-test-resources from a layout test over HTTP.
> 
> I'm not entirely sure I understand the use-case here, but if you'd like to remap what directories are available at what location when using new-run-webkit-tests's HTTP server, you can use aliases the way http://trac.webkit.org/changeset/79630 works (see the Tools/Scripts changes).

So, the remapping I want is already there (/js-test-resources -> fast/js/resources), the trick is that these tests are running in Chromium's ui_tests against a limited set of LayoutTests under chrome/test/data/layout_tests.  But port.layout_tests_dir() returns third_party/WebKit/LayoutTests, which on many folks' checkouts (including the try bots) is empty.  See http://codereview.chromium.org/6727001/diff/2005/chrome/test/ui/ui_test.cc for how I plan to use this flag.

[WebKit Commit Bot]

Comment on attachment 86550 [details]
Patch

Clearing flags on attachment: 86550

Committed r81834: <http://trac.webkit.org/changeset/81834>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.