Bug 56878 – WebKit2: Need API to manage the Media Cache

• Component: WebKit2
• Status: RESOLVED FIXED

[Brian Weinstein]

We need WebKit2 API to manager the Media Cache.

1) List of all hostnames with entries in the media cache
2) Delete media cache entries for a host name
3) Delete all media cache entries.

<rdar://problem/9082503>

[Brian Weinstein]

Created attachment 86544 [details]
[PATCH] Fix

[Brian Weinstein]

Created attachment 86551 [details]
[PATCH] Fix (Applies cleanly to ToT)

[WebKit Review Bot]

Attachment 86551 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/WebMediaCacheManagerProxy.cpp:30:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebKit2/UIProcess/WebMediaCacheManagerProxy.h:38:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebKit2/WebProcess/MediaCache/WebMediaCacheManager.h:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 3 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Adler]

Comment on attachment 86551 [details]
[PATCH] Fix (Applies cleanly to ToT)

View in context: https://bugs.webkit.org/attachment.cgi?id=86551&action=review

>> Source/WebKit2/UIProcess/WebMediaCacheManagerProxy.cpp:30
>> +#include "WebContext.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Should fix the sorting here just like the style bot says.

>> Source/WebKit2/UIProcess/WebMediaCacheManagerProxy.h:38
>> +    class ArgumentDecoder;
> 
> Code inside a namespace should not be indented.  [whitespace/indent] [4]

This, I think, is a style bot mistake, so OK to leave as is. I’m not sure everyone else agrees.

> Source/WebKit2/WebProcess/MediaCache/WebMediaCacheManager.cpp:34
> +#include "WebProcess.h"
> +
> +#include <WebCore/NotImplemented.h>

We don’t leave spaces in cases like this.

[Brian Weinstein]

(In reply to comment #4)
> (From update of attachment 86551 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86551&action=review
> 
> >> Source/WebKit2/UIProcess/WebMediaCacheManagerProxy.cpp:30
> >> +#include "WebContext.h"
> > 
> > Alphabetical sorting problem.  [build/include_order] [4]
> 
> Should fix the sorting here just like the style bot says.

Fixed.

> 
> >> Source/WebKit2/UIProcess/WebMediaCacheManagerProxy.h:38
> >> +    class ArgumentDecoder;
> > 
> > Code inside a namespace should not be indented.  [whitespace/indent] [4]
> 
> This, I think, is a style bot mistake, so OK to leave as is. I’m not sure everyone else agrees.

I tend to think it is a style bot mistake as well. I'll leave it as it is. This seems to be a style I've seen used a lot especially in WebKit2.

> 
> > Source/WebKit2/WebProcess/MediaCache/WebMediaCacheManager.cpp:34
> > +#include "WebProcess.h"
> > +
> > +#include <WebCore/NotImplemented.h>
> 
> We don’t leave spaces in cases like this.

Fixed.

[WebKit Review Bot]

http://trac.webkit.org/changeset/81788 might have broken Qt Linux Release

[Brian Weinstein]

Landed in r81788 with build fix in r81790. Next part of this bug is filling in the FIXMEs in WebMediaCacheManager to actually call the functions to do work on the media cache.

[Brian Weinstein]

Created attachment 86702 [details]
[PATCH] Call HTMLMediaElement from WebKit2

[Maciej Stachowiak]

Comment on attachment 86702 [details]
[PATCH] Call HTMLMediaElement from WebKit2

r=me

[Brian Weinstein]

Landed the rest in r81836.