Bug 5687

Summary: inline more ScopeChain functions for speed
Product: WebKit Reporter: Darin Adler <darin>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
make more functions inline for speed eric: review+

Darin Adler
Reported 2005-11-09 08:48:15 PST
Attachments
make more functions inline for speed (4.06 KB, patch)
2005-11-09 08:48 PST, Darin Adler 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2005-11-09 08:48:39 PST
Created attachment 4650 [details] make more functions inline for speed
Maciej Stachowiak
Comment 2 2005-11-17 00:12:43 PST
I suspect this might not make a speed difference any more, now that an iterator with inline operations is used to traverse the scope chain during execution, instead of making a copy and popping.
Darin Adler
Comment 3 2005-11-23 17:28:30 PST
Comment on attachment 4650 [details] make more functions inline for speed While I understand that these functions are no longer as hot as they used to be, I still think inlining them makes sense -- they are only used in 1 or 2 places and they are performance-critiical places.
Maciej Stachowiak
Comment 4 2005-11-24 00:45:03 PST
Upon further reading I think inlining mark() will almost certainly make a difference but I am not really sure about the others - worth measuring and profiling.
Eric Seidel (no email)
Comment 5 2005-11-24 12:12:26 PST
Comment on attachment 4650 [details] make more functions inline for speed The code looks fine. However while you're in there, you might as well clean up the formatting of ScopeChain::bottom() (spacing) and ScopeChain::pop() (one line if) to follow our published coding guidelines.
Note You need to log in before you can comment on or make changes to this bug.