Bug 5686

Summary: make Shared::deref faster by eliminating multiple branches
Product: WebKit Reporter: Darin Adler <darin>
Component: WebKit Misc.Assignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Enhancement    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
See Also: https://bugs.webkit.org/show_bug.cgi?id=195661
Attachments:
Description Flags
get rid of the double if statement in deref without changing semantics eric: review+

Darin Adler
Reported 2005-11-09 08:42:45 PST
Attachments
get rid of the double if statement in deref without changing semantics (4.85 KB, patch)
2005-11-09 08:43 PST, Darin Adler 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2005-11-09 08:43:21 PST
Created attachment 4649 [details] get rid of the double if statement in deref without changing semantics
Eric Seidel (no email)
Comment 2 2005-11-09 12:15:36 PST
Comment on attachment 4649 [details] get rid of the double if statement in deref without changing semantics The ref changes look fine. Changing RenderWidget not to be a subclass of Shared seems a bit unnecessary (all the Shared functions are inline to begin with), but it's not a big deal either.
Note You need to log in before you can comment on or make changes to this bug.