Bug 56852

Summary: build.webkit.org bots using old-run-webkit-tests should upload results to Chromium's test dashboards
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: ojan, ossy, sam
Priority: P2 Keywords: InRadar, ToolsHitList
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 32954    
Bug Blocks:    

Description Adam Roben (:aroben) 2011-03-22 11:42:43 PDT
Chromium runs some test dashboards at <http://test-results.appspot.com/>. It would be useful to be able to use these dashboards to analyze test failures on build.webkit.org bots that use old-run-webkit-tests. We should make the bots that use old-run-webkit-tests on build.webkit.org upload their results to the dashboard!
Comment 1 Adam Roben (:aroben) 2011-03-22 11:43:38 PDT
<rdar://problem/9169960>
Comment 2 Ojan Vafai 2011-03-22 23:49:52 PDT
Sorry if this is information overload.

We need to upload 3 JSON files (incremental_results.json, full_results.json and expectations.json) to test-results.appspot.com and then update the html for the dashboard to know about the new bots. The hard part is generating the JSON. Once that's done, I'm happy to modify the HTML appropriately.

You're probably best off just working backwards from the actual files at http://test-results.appspot.com/testfile?testtype=layout-tests.

Here's a somewhat outdated guide on the JSON format for incremental_results.json and expectations.json: https://sites.google.com/a/chromium.org/dev/developers/design-documents/layout-tests-results-dashboard


full_results.json: This is the simplest of the JSON files. This is generated by new-run-webkit-tests. The server does not modify it.

a simple mapping from test-name to {"expected":"PASS","time_ms":14,"actual":"PASS"}
For non-chromium ports, expected is always "PASS". Actual is dependent on the type of failure. Possible values are TEXT, IMAGE, IMAGE+TEXT, CRASH, TIMEOUT.

If you want a somewhat incremental way of approaching this, the treemap dashboard only needs this JSON file.


expectations.json: This is generated by new-run-webkit-tests. The server does not modify it.

See the dev.chromium.org link above for info on the format. For the sake of non-chromium ports though, this file just consistent of aggregating the data from all the Skipped lists and listing SKIP and the platform as the modifiers for each of those tests. The expectation is always PASS. Tests that are not in a Skipped list don't need to be included in this file.


incremental_results.json: This is the most complicated of the JSON files. Here's the python code that generates the incremental_results.json file: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py

results.json and results-small.json contain data on the history of runs. new-run-webkit-tests only uploads incremental_results.json which is the same format, but with only one run's data. One the server-side, this data is merged into results.json and results-small.json.
Comment 3 Ojan Vafai 2011-03-23 00:03:29 PDT
Also, we have a test server that you can upload trash data to as needed: http://test-results-test.appspot.com/

I'll look into whether it's possible to give more people admin access to the servers.
Comment 4 Adam Roben (:aroben) 2011-03-23 08:49:40 PDT
Looks like we already have a bug for this.

*** This bug has been marked as a duplicate of bug 32954 ***
Comment 5 Adam Roben (:aroben) 2011-03-23 08:50:34 PDT
I guess bug 32954 is really a subtask of this one. It is step 1 in getting results from these bots on the dashboards.
Comment 6 Adam Roben (:aroben) 2011-04-26 14:42:53 PDT
*** Bug 59502 has been marked as a duplicate of this bug. ***
Comment 7 Adam Roben (:aroben) 2011-07-21 15:48:46 PDT
We're pretty close to having all bots using NRWT now, at which point this won't be needed. I don't think it's worth the effort to do this at this point.