| Summary: | [Qt] WebGL: renderbufferStorage() fails with internal format GL_RGBA4 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jarkko Sakkinen <jarkko.j.sakkinen> | ||||||
| Component: | WebGL | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, benjamin, commit-queue, eric, jarkko.j.sakkinen, webkit.review.bot | ||||||
| Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Jarkko Sakkinen
2011-03-22 05:23:43 PDT
I'm implementing fix in the spirit of this message: http://www.khronos.org/webgl/public-mailing-list/archives/1010/msg00126.html Created attachment 86455 [details]
Fallback to GL_RGBA on desktop OpenGL.
Comment on attachment 86455 [details] Fallback to GL_RGBA on desktop OpenGL. View in context: https://bugs.webkit.org/attachment.cgi?id=86455&action=review > Source/WebCore/ChangeLog:10 > + I would prefer you mention the test you are fixing with this patch in the changelog. Just so it is explicit how this change is tested. > Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:1099 > +#if !defined (QT_OPENGL_ES_2) We usually do not put space between defined and the parenthesis. > Source/WebCore/platform/graphics/qt/GraphicsContext3DQt.cpp:1100 > + if (internalformat == RGBA4 || internalformat == RGB565 || internalformat == RGB5_A1) What about DEPTH_STENCIL and DEPTH_COMPONENT16? (just saw those have special case in GraphicsContext3DOpenGL). You're right about your comments about GraphicsContext3DOpenGL. In this case we should use the same logic as there. I'll revise the patch. Thanks. Created attachment 86460 [details]
Fixed defects that benjaminp reported.
Comment on attachment 86460 [details] Fixed defects that benjaminp reported. Clearing flags on attachment: 86460 Committed r81672: <http://trac.webkit.org/changeset/81672> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/81672 might have broken GTK Linux 32-bit Debug The following tests are not passing: inspector/debugger/debug-inlined-scripts.html |