Bug 56815

Summary: Web Inspector: protocol cleanup. DatabaseAgent.
Product: WebKit Reporter: Ilya Tikhonovsky <loislo>
Component: Web Inspector (Deprecated)Assignee: Ilya Tikhonovsky <loislo>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, aroben, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 54856    
Attachments:
Description Flags
[patch] initial version yurys: review+

Ilya Tikhonovsky
Reported 2011-03-22 02:09:07 PDT
see protocol metabug: - All events should use notification wording, not command wording: addConsoleMessage->consoleMessage, updateConsoleMessageRepeatCount->consoleMessageRepeatCountUpdates, etc. addDatabase was renamed to DatabaseOpened.
Attachments
[patch] initial version (8.89 KB, patch)
2011-03-22 02:13 PDT, Ilya Tikhonovsky 		yurys: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ilya Tikhonovsky
Comment 1 2011-03-22 02:13:32 PDT
Created attachment 86445 [details] [patch] initial version
Yury Semikhatsky
Comment 2 2011-03-22 02:32:53 PDT
Comment on attachment 86445 [details] [patch] initial version View in context: https://bugs.webkit.org/attachment.cgi?id=86445&action=review > LayoutTests/ChangeLog:10 > + addConsoleMessage->consoleMessage, updateConsoleMessageRepeatCount->consoleMessageRepeatCountUpdates, etc. The change log describes changes that are not in this CL. Please fix.
Ilya Tikhonovsky
Comment 3 2011-03-22 02:42:40 PDT
Committed r81651: <http://trac.webkit.org/changeset/81651>
WebKit Review Bot
Comment 4 2011-03-22 03:20:13 PDT
http://trac.webkit.org/changeset/81651 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: inspector/protocol/database-agent.html
Adam Roben (:aroben)
Comment 5 2011-03-22 05:14:38 PDT
Looks like this new test is failing on many bots.
Note You need to log in before you can comment on or make changes to this bug.