Bug 56808

Summary:

[chromium] Remove Gears from Chrome WebKit

Product:

WebKit

Reporter:

noel gordon <noel.gordon>

Component:

WebKit Misc.

Assignee:

noel gordon <noel.gordon>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aa, commit-queue, ojan, tony

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Windows 7

Attachments:

Description	Flags
Patch	none

noel gordon

Reported 2011-03-22 01:19:21 PDT

chrome bug http://code.google.com/p/chromium/issues/detail?id=51934

Attachments
Patch (14.70 KB, patch) 2011-03-22 01:52 PDT, noel gordon	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

noel gordon

Comment 1 2011-03-22 01:52:57 PDT

Created attachment 86441 [details] Patch

Tony Chang

Comment 2 2011-03-22 10:00:25 PDT

Comment on attachment 86441 [details] Patch I assume we will get rid of identity in a follow up patch? We'll need to have both function signatures and do a 3 sided patch.

WebKit Commit Bot

Comment 3 2011-03-22 10:27:56 PDT

Comment on attachment 86441 [details] Patch Clearing flags on attachment: 86441 Committed r81676: <http://trac.webkit.org/changeset/81676>

WebKit Commit Bot

Comment 4 2011-03-22 10:28:01 PDT

All reviewed patches have been landed. Closing bug.

noel gordon

Comment 5 2011-03-22 15:04:49 PDT

chromium win trys were ok for the record: http://build.chromium.org/p/tryserver.chromium/builders/win/builds/22412 http://build.chromium.org/p/tryserver.chromium/builders/win_layout/builds/581 http://build.chromium.org/p/tryserver.chromium/builders/win_layout_rel/builds/145

noel gordon

Comment 6 2011-03-22 15:55:52 PDT

> I assume we will get rid of identity in a follow up patch? We'll need to have both function signatures and do a 3 sided patch. Yes in a follow up patch, filed bug 56875 about that.

Note You need to log in before you can comment on or make changes to this bug.