Bug 56800

Summary:

[fileapi] New resolve url tests don't pass on Chromium. Skipping them.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

adamk, commit-queue, levin

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Fixed merge conflicts	none

Pavel Feldman

Reported 2011-03-21 22:15:50 PDT

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=http%2Ftests%2Ffilesystem%2Fworkers%2Fresolve-url-sync.html%2Chttp%2Ftests%2Ffilesystem%2Fworkers%2Fresolve-url.html http/tests/filesystem/workers/resolve-url-sync.html = TIMEOUT http/tests/filesystem/workers/resolve-url.html = TIMEOUT

Attachments
Patch (2.08 KB, patch) 2011-03-22 10:29 PDT, Adam Klein	no flags	Details Formatted Diff Diff
Fixed merge conflicts (2.25 KB, patch) 2011-03-22 15:31 PDT, Adam Klein	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2011-03-21 22:25:19 PDT

Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog M LayoutTests/platform/chromium/test_expectations.txt Committed r81646

David Levin

Comment 2 2011-03-21 22:27:22 PDT

http/tests/filesystem/workers should just be skipped for chromium (since workers won't function in drt).

Adam Klein

Comment 3 2011-03-22 10:29:42 PDT

Created attachment 86473 [details] Patch

Adam Klein

Comment 4 2011-03-22 15:23:50 PDT

Reopening to poke commit-queue.

WebKit Commit Bot

Comment 5 2011-03-22 15:27:54 PDT

Comment on attachment 86473 [details] Patch Rejecting attachment 86473 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2 Last 500 characters of output: apply', u'--reviewer', u'David Levin', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #2 FAILED at 3289. 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'David Levin', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8224442

Adam Klein

Comment 6 2011-03-22 15:31:07 PDT

Created attachment 86523 [details] Fixed merge conflicts

WebKit Commit Bot

Comment 7 2011-03-22 17:07:44 PDT

Comment on attachment 86523 [details] Fixed merge conflicts Clearing flags on attachment: 86523 Committed r81725: <http://trac.webkit.org/changeset/81725>

WebKit Commit Bot

Comment 8 2011-03-22 17:07:48 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.