Bug 56764

Summary:

QT plug-in loads controller at top of movie not bottom

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	sam: review+

Description Anders Carlsson 2011-03-21 12:56:57 PDT

QT plug-in loads controller at top of movie not bottom

Comment 1 Anders Carlsson 2011-03-21 12:59:18 PDT

Created attachment 86355 [details]
Patch

Comment 2 Sam Weinig 2011-03-21 13:02:23 PDT

Comment on attachment 86355 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86355&action=review

Otherwise, r=me.

> Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:234
> +            RetainPtr<CALayer> realPluginLayer(AdoptNS, reinterpret_cast<CALayer *>(value));

This adoption seems wrong.

Comment 3 Anders Carlsson 2011-03-21 13:03:56 PDT

Committed r81604: <http://trac.webkit.org/changeset/81604>