Bug 56736

Summary: [chromium] MAC: should pass CSS3 elliptical gradient tests
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: CSSAssignee: noel gordon <noel.gordon>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, senorblanco, webkit.review.bot
Priority: P2 Keywords: LayoutTestFailure
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.6   
Bug Depends on: 51841    
Bug Blocks: 55745    
Attachments:
Description Flags
Patch
none
Patch for landing none

noel gordon
Reported 2011-03-21 04:17:33 PDT
Following tests are not passing in dumpRenderTree --chromium. fast/gradients/css3-radial-gradients.html fast/gradients/css3-radial-gradients2.html fast/gradients/css3-radial-gradients3.html fast/gradients/css3-repeating-radial-gradients.html
Attachments
Patch (253.97 KB, patch)
2011-12-21 23:11 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
Patch for landing (253.98 KB, patch)
2011-12-22 18:30 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
noel gordon
Comment 1 2011-03-21 05:01:19 PDT
Chromium currently builds against the OSX 10.5 SDK on both LEOPARD and SNOW LEOPARD, which causes BUILDING_ON_LEOPARD to be defined via <wtf/Platform.h>. Gradient.h defines #define USE_CG_SHADING defined(BUILDING_ON_TIGER) || defined(BUILDING_ON_LEOPARD) making the gradient paint path use the older CGShaders - CGShadingCreateRadial is used for radial gradients, but does not support ellipsoidal gradients (this bug). Using the newer CGContextDrawRadialGradient for radial gradients would fix the bug, but it would also cause memory leaks for linear gradients via CGContextDrawLinearGradient on 10.5 SDK builds of the Gradient.h code (refer to changeset 54970). Best to fix this once Chromium has real 10.6 SDK build/release system (USE_CG_SHADING will be false) and rebaseline the layout tests to close this bug.
noel gordon
Comment 2 2011-12-21 23:03:40 PST
Alternative fix, use skia on the mac, the skai implementation know how to draws ellipsoids as required by these tests.
noel gordon
Comment 3 2011-12-21 23:11:59 PST
Created attachment 120277 [details] Patch
noel gordon
Comment 4 2011-12-21 23:22:07 PST
ahem, the skia implementation knows how to draws ellipsoids bug 51841 as required by these tests
Stephen White
Comment 5 2011-12-22 06:48:17 PST
Comment on attachment 120277 [details] Patch Thanks! r=me
noel gordon
Comment 6 2011-12-22 18:30:59 PST
Created attachment 120421 [details] Patch for landing
Stephen White
Comment 7 2011-12-22 19:05:08 PST
Comment on attachment 120421 [details] Patch for landing OK.
WebKit Review Bot
Comment 8 2011-12-23 04:06:05 PST
Comment on attachment 120421 [details] Patch for landing Clearing flags on attachment: 120421 Committed r103621: <http://trac.webkit.org/changeset/103621>
WebKit Review Bot
Comment 9 2011-12-23 04:06:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.