Bug 56698

Summary: [GTK] Simplify GObjectEventListener
Product: WebKit Reporter: Xan Lopez <xan.lopez>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Xan Lopez
Reported 2011-03-18 17:52:00 PDT
There's really no need to have a special member variable for DOMWindow, since it's also an EventTarget.
Attachments
Patch (7.01 KB, patch)
2011-03-18 17:54 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2011-03-18 17:54:41 PDT
Created attachment 86249 [details] Patch
Martin Robinson
Comment 2 2011-03-18 20:04:14 PDT
Comment on attachment 86249 [details] Patch Nice cleanup!
Xan Lopez
Comment 3 2011-03-19 07:25:25 PDT
Comment on attachment 86249 [details] Patch Clearing flags on attachment: 86249 Committed r81550: <http://trac.webkit.org/changeset/81550>
Xan Lopez
Comment 4 2011-03-19 07:25:32 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2011-03-19 12:57:16 PDT
http://trac.webkit.org/changeset/81550 might have broken Windows 7 Release (Tests) The following tests are not passing: fast/workers/storage/multiple-databases-garbage-collection.html fast/workers/storage/open-database-inputs-sync.html storage/multiple-databases-garbage-collection.html storage/open-database-creation-callback-isolated-world.html storage/open-database-creation-callback.html storage/quota-tracking.html storage/statement-error-callback-isolated-world.html storage/statement-success-callback-isolated-world.html storage/transaction-callback-isolated-world.html storage/transaction-error-callback-isolated-world.html storage/transaction-success-callback-isolated-world.html
Note You need to log in before you can comment on or make changes to this bug.