Bug 56679

Summary:

Enhancement of CSS3 background tests through new tests

Product:

WebKit

Reporter:

chereddy <srchereddy>

Component:

CSS

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED CONFIGURATION CHANGED

Severity:

Normal

CC:

ahmad.saleem792, ap, hyatt, rniwa, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
new css3-background tests	none
new patch (css3-background tests)	kling: review-

chereddy

Reported 2011-03-18 14:08:21 PDT

Add new tests to address the coverage gaps with existing CSS3 background tests.

Attachments
new css3-background tests (700.85 KB, patch) 2011-03-18 14:10 PDT, chereddy	no flags	Details Formatted Diff Diff
new patch (css3-background tests) (277.44 KB, patch) 2011-03-22 08:11 PDT, chereddy	kling: review-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

chereddy

Comment 1 2011-03-18 14:10:42 PDT

Created attachment 86208 [details] new css3-background tests To address the coverage gaps with existing CSS3 background tests, I am proposing to add these new tests.

Simon Fraser (smfr)

Comment 2 2011-03-20 21:06:24 PDT

Where did these tests come from?

chereddy

Comment 3 2011-03-21 10:43:38 PDT

We have written these new tests as per following W3C css3-background specification. http://www.w3.org/TR/css3-background/ We verified the W3C CSS2.1 test suite (location: http://test.csswg.org/suites/css2.1/20110111/html4/chapter-14.html) and added new tests for gaps as per the above new CSS3 background specification. We are also automating the above W3C CSS2.1 background tests. We will submit those tests to webkit in another patch.

Simon Fraser (smfr)

Comment 4 2011-03-21 10:51:51 PDT

Why do they contain <link rel="author" title="Microsoft" href="http://www.microsoft.com/">?

chereddy

Comment 5 2011-03-22 08:11:22 PDT

Created attachment 86461 [details] new patch (css3-background tests) 1.For consistency with W3C tests, we used the test template from css2.1 tests. We forgot to modify the meta data in few tests from "<link rel="author" title="Microsoft" href="http://www.microsoft.com/">" to "<link rel="author" title="Nokia" href="http://www.nokia.com/">". Apologize for the confusion. Now we corrected the tests and attached the new patch (name: css3-background-tests-1.patch). 2. To reduce the patch size, we removed the redundant image files from the support folder in this new patch.

Andreas Kling

Comment 6 2011-04-26 17:04:29 PDT

Comment on attachment 86461 [details] new patch (css3-background tests) There should only be one ChangeLog entry per patch (per relevant ChangeLog file.)

Ahmad Saleem

Comment 7 2022-06-27 14:15:13 PDT

I think these are now part of WPT and have landed - https://wpt.fyi/results/css/css-backgrounds?label=experimental&label=master&aligned Is this required or this can be closed? Thanks!

Ryosuke Niwa

Comment 8 2022-06-27 14:35:59 PDT

Yeah, we're importing these as a part of WPT.

Note You need to log in before you can comment on or make changes to this bug.