Bug 56670

Summary:

<dfn> should have font-style: italic by default

Product:

WebKit

Reporter:

Aryeh Gregor <ayg>

Component:

CSS

Assignee:

Nayan Kumar K <nayankk>

Status:

RESOLVED FIXED

Severity:

Minor

CC:

ayg, cmarcelo, dglazkov, mrobinson, nayankk, shanestephens, webkit.review.bot

Priority:

Keywords:

EasyFix

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
Default <dfn> tag font style is set to italic	none
Patch to make text within <dfn> tag italicized.	webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cr-linux-02	none
Updated patch	abarth: review+, abarth: commit-queue-
Updated the patch. Now document.writeln is called without checking for window.layoutTestController	none
Updated the patch. Now document.writeln is called without checking for layoutTestController.	none

Aryeh Gregor

Reported 2011-03-18 13:30:54 PDT

Per HTML5 spec: "address, cite, dfn, em, i, var { font-style: italic; }" http://www.whatwg.org/specs/web-apps/current-work/multipage/rendering.html#fonts-and-colors Text in this test-case is italic in IE 9 RC, Firefox 4 RC, and Opera 11, but not Chrome 11 dev or Safari 5.0.3: data:text/html,<!doctype html><dfn>Test</dfn>

Attachments
Default <dfn> tag font style is set to italic (3.49 KB, patch) 2011-07-11 00:28 PDT, Nayan Kumar K	no flags	Details Formatted Diff Diff
Patch to make text within <dfn> tag italicized. (3.48 KB, patch) 2011-07-11 00:36 PDT, Nayan Kumar K	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ec2-cr-linux-02 (1.32 MB, application/zip) 2011-07-11 01:54 PDT, WebKit Review Bot	no flags	Details
Updated patch (3.47 KB, patch) 2011-07-11 16:27 PDT, Nayan Kumar K	abarth: review+ abarth: commit-queue-	Details Formatted Diff Diff
Updated the patch. Now document.writeln is called without checking for window.layoutTestController (2.03 KB, patch) 2011-08-29 00:09 PDT, Nayan Kumar K	no flags	Details Formatted Diff Diff
Updated the patch. Now document.writeln is called without checking for layoutTestController. (2.75 KB, patch) 2011-08-29 00:22 PDT, Nayan Kumar K	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Nayan Kumar K

Comment 1 2011-07-11 00:28:00 PDT

Created attachment 100251 [details] Default <dfn> tag font style is set to italic Proposed patch to make default font style of <dfn> attribute as italic.

Nayan Kumar K

Comment 2 2011-07-11 00:36:22 PDT

Created attachment 100252 [details] Patch to make text within <dfn> tag italicized. Modified patch to make text within dfn tag italicized.

WebKit Review Bot

Comment 3 2011-07-11 01:54:24 PDT

Comment on attachment 100252 [details] Patch to make text within <dfn> tag italicized. Attachment 100252 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9006812 New failing tests: http/tests/misc/slow-loading-mask.html fast/css/dfn-default-font-style.html fast/blockflow/japanese-rl-selection.html svg/transforms/text-with-mask-with-svg-transform.svg fast/backgrounds/background-leakage.html fast/box-shadow/scaled-box-shadow.html fast/backgrounds/repeat/negative-offset-repeat.html svg/W3C-SVG-1.1/struct-use-01-t.svg transforms/2d/hindi-rotated.html svg/repaint/filter-repaint.svg fast/blockflow/japanese-lr-selection.html

WebKit Review Bot

Comment 4 2011-07-11 01:54:28 PDT

Created attachment 100255 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Nayan Kumar K

Comment 5 2011-07-11 16:27:23 PDT

Created attachment 100377 [details] Updated patch

Adam Barth

Comment 6 2011-08-25 00:36:39 PDT

Comment on attachment 100377 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=100377&action=review > LayoutTests/fast/css/dfn-default-font-style.html:18 > + document.writeln(testresult); Presumably we can call document.writeln even without window.layoutTestController.

Nayan Kumar K

Comment 7 2011-08-29 00:09:03 PDT

Created attachment 105466 [details] Updated the patch. Now document.writeln is called without checking for window.layoutTestController

Nayan Kumar K

Comment 8 2011-08-29 00:22:37 PDT

Created attachment 105470 [details] Updated the patch. Now document.writeln is called without checking for layoutTestController.

WebKit Review Bot

Comment 9 2011-08-29 13:07:05 PDT

Comment on attachment 105470 [details] Updated the patch. Now document.writeln is called without checking for layoutTestController. Clearing flags on attachment: 105470 Committed r94006: <http://trac.webkit.org/changeset/94006>

WebKit Review Bot

Comment 10 2011-08-29 13:07:13 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.