Summary: | [GTK] Expose menu items and menus as children of a menu bar | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mario Sanchez Prada <mario> | ||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | jdiggs, mrobinson | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 30796 | ||||||
Attachments: |
|
Description
Mario Sanchez Prada
2011-03-18 10:43:01 PDT
Created attachment 89015 [details]
Patch proposal + Layout test
Attaching simple patch to fix this along with a cross platform test (needs adding new results for other platforms, say, Mac and Win)
Comment on attachment 89015 [details] Patch proposal + Layout test View in context: https://bugs.webkit.org/attachment.cgi?id=89015&action=review otherwise looks good. r=me > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2968 > return MenuItemRole; It looks like we're calling parentObjectUnignored()->ariaRoleAttribute() potentially three times. I think that value should be stored local. parentObjectUnignored() can be little expensive. (In reply to comment #2) > (From update of attachment 89015 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=89015&action=review > > otherwise looks good. r=me > > > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2968 > > return MenuItemRole; > > It looks like we're calling parentObjectUnignored()->ariaRoleAttribute() potentially three times. I think that value should be stored local. parentObjectUnignored() can be little expensive. I'll fix that right before committing. Thanks! Committed r83606: <http://trac.webkit.org/changeset/83606> |