Bug 56630

Summary: Pixel tests don't work in WebKitTestRunner on Windows
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, sam, webkit.review.bot
Priority: P2 Keywords: PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Bug Depends on:    
Bug Blocks: 49007    
Attachments:
Description Flags
WIP patch (won't build on Mac)
none
Patch aroben: review+

Adam Roben (:aroben)
Reported 2011-03-18 01:17:15 PDT
Pixel test support isn't implemented in WebKitTestRunner on Windows. We should fix that!
Attachments
WIP patch (won't build on Mac) (25.25 KB, patch)
2011-03-18 01:18 PDT, Adam Roben (:aroben) 		no flags
DetailsFormatted DiffDiff
Patch (39.39 KB, patch)
2011-03-18 12:21 PDT, Sam Weinig 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-03-18 01:18:36 PDT
Created attachment 86143 [details] WIP patch (won't build on Mac)
Sam Weinig
Comment 2 2011-03-18 12:21:23 PDT
Created attachment 86193 [details] Patch
Sam Weinig
Comment 3 2011-03-18 12:24:11 PDT
Committed r81494: <http://trac.webkit.org/changeset/81494>
WebKit Review Bot
Comment 4 2011-03-18 12:33:28 PDT
http://trac.webkit.org/changeset/81494 might have broken Windows Release (Build) and Windows Debug (Build)
Note You need to log in before you can comment on or make changes to this bug.