Bug 56598 – [chromium] Video colors have wrong brightness/contrast

• Component: New Bugs
• Status: RESOLVED FIXED

[Victoria Kirst]

[chromium] Video colors have wrong brightness/contrast

[Victoria Kirst]

Created attachment 86100 [details]
Patch

[WebKit Review Bot]

Attachment 86100 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/graphics/chromium/ShaderChromium.cpp:283:  y_raw is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/graphics/chromium/ShaderChromium.cpp:284:  u_unsigned is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/graphics/chromium/ShaderChromium.cpp:285:  v_unsigned is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Victoria Kirst]

Created attachment 86101 [details]
Patch

[WebKit Review Bot]

Attachment 86101 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/graphics/chromium/ShaderChromium.cpp:283:  y_raw is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/graphics/chromium/ShaderChromium.cpp:284:  u_unsigned is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Source/WebCore/platform/graphics/chromium/ShaderChromium.cpp:285:  v_unsigned is incorrectly named. Don't use underscores in your identifier names.  [readability/naming] [4]
Total errors found: 3 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Kenneth Russell]

Comment on attachment 86101 [details]
Patch

Looks good to me. I'm ignoring the style queue since it's flagging variable names in embedded GLSL shaders which use a different convention.

[Vangelis Kokkevis]

Comment on attachment 86101 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=86101&action=review

> Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:63
> +const float VideoLayerChromium::yuvAdjust[3] = {

Since these values are fixed, why not put them straight in the shader?  I guess the same would apply for the conversion matrix too!

[Vangelis Kokkevis]

(In reply to comment #6)
> (From update of attachment 86101 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=86101&action=review
> 
> > Source/WebCore/platform/graphics/chromium/VideoLayerChromium.cpp:63
> > +const float VideoLayerChromium::yuvAdjust[3] = {
> 
> Since these values are fixed, why not put them straight in the shader?  I guess the same would apply for the conversion matrix too!

Never mind.  Ken reminded me about the comman vs period issue which resulted in these being passed as uniforms...

[WebKit Commit Bot]

Comment on attachment 86101 [details]
Patch

Clearing flags on attachment: 86101

Committed r81414: <http://trac.webkit.org/changeset/81414>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.