Bug 56527

Summary: Viewport test for user-scalable=yes
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, ddkilzer, eric, joepeck, kenneth, pnormand, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
[PATCH] Add Tests none

Joseph Pecoraro
Reported 2011-03-16 19:51:54 PDT
Apparently there were no tests for user-scalable=yes. Now that we have userScalable output in DRT results we should add one so we see it is an explicit 1.0.
Attachments
[PATCH] Add Tests (3.92 KB, patch)
2011-03-16 21:36 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2011-03-16 21:36:55 PDT
Created attachment 86026 [details] [PATCH] Add Tests This completely fabricated the expected results. But I think they are correct and it shouldn't require me to pull expected results from the bots (very time consuming!).
WebKit Commit Bot
Comment 2 2011-03-17 02:17:48 PDT
Comment on attachment 86026 [details] [PATCH] Add Tests Clearing flags on attachment: 86026 Committed r81341: <http://trac.webkit.org/changeset/81341>
WebKit Commit Bot
Comment 3 2011-03-17 02:17:52 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 4 2011-03-17 03:07:14 PDT
http://trac.webkit.org/changeset/81341 might have broken Qt Linux Release The following tests are not passing: fast/viewport/viewport-131.html
Philippe Normand
Comment 5 2011-03-17 03:50:44 PDT
fast/viewport/viewport-131.html also fails on GTK. Joseph, do we need platform-specific baselines for this?
Joseph Pecoraro
Comment 6 2011-03-17 09:19:16 PDT
Looks like I was wrong about the user-scalable=no expected results. That automatically clamps the scale size. I'll land a fix for that in: <http://webkit.org/b/56556> [GTK] fast/viewport/viewport-131.html fails
Note You need to log in before you can comment on or make changes to this bug.