Bug 56499

Summary: webkit-patch does not support HTTPS proxies due to old version of Mechanize
Product: WebKit Reporter: Keith Kyzivat <kamaji>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, benjamin, cjerdonek, commit-queue, eric, kling, laszlo.gombos, levin, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Keith Kyzivat 2011-03-16 16:14:42 PDT 
webkit-patch currently does not support HTTPS proxies.  Many companies use proxies to access the public internet, and this is needed in order to be able to use webkit-patch.

This is due to a limitation in the older version of mechanize that we use.
Mechanize supports HTTPS proxies in newer versions of Mechanize, and I have determined that version 0.2.4 works fine with webkit-patch upload (I have not tested more than that).

Here is a post from the author of mechanize indicating that HTTPS proxy support was present in his git repo as of 31-Jan-2010, and it's been a year since then, and 5 releases since 0.1.11.
http://blog.gmane.org/gmane.comp.python.wwwsearch.general/month=20100201
http://pypi.python.org/packages/source/m/mechanize/

I would like to see the webkit scripts update to use mechanize 0.2.4 if possible.
Comment 1 Keith Kyzivat 2011-03-16 16:24:21 PDT 
Created attachment 85996 [details]
Patch

update mechanize to 0.2.4
Comment 2 Andreas Kling 2011-03-16 20:16:23 PDT 
CC'ing folks who have poked the autoinstall stuff in the past.
Comment 3 Adam Barth 2011-03-16 22:48:11 PDT 
Comment on attachment 85996 [details]
Patch

Looks fine, but Eric should take a look too.
Comment 4 Eric Seidel (no email) 2011-03-16 22:48:45 PDT 
Comment on attachment 85996 [details]
Patch

LGTM!  Thanks!
Comment 5 WebKit Commit Bot 2011-03-17 05:11:29 PDT 
Comment on attachment 85996 [details]
Patch

Clearing flags on attachment: 85996

Committed r81348: <http://trac.webkit.org/changeset/81348>
Comment 6 WebKit Commit Bot 2011-03-17 05:11:35 PDT 
All reviewed patches have been landed.  Closing bug.