Summary: | Render fonts using skia when requested by platform context. | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Guillory <ctguil> | ||||||||||
Component: | Printing | Assignee: | Nobody <webkit-unassigned> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | abarth, brettw, commit-queue, dglazkov, eric, reed, scr, vandebo, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | All | ||||||||||||
Attachments: |
|
Description
Chris Guillory
2011-03-15 18:48:14 PDT
What else needs to be done for this, outside of ENABLE(SKIA_TEXT) ? Created attachment 85923 [details]
Proposed patch.
Attachment 85923 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8188135 Created attachment 86557 [details]
Proposed patch.
Linux build should succeed.
Created attachment 86559 [details]
Proposed patch.
Brett can you have a look. The eventual goal is to always use skia on windows for drawing text but that will take some time. Comment on attachment 86559 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=86559&action=review LGTM > Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:266 > + // Check if native font rendering is allowed. This comment seems redundant. I would just delete it. (In reply to comment #7) > (From update of attachment 86559 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86559&action=review > > LGTM > > > Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:266 > > + // Check if native font rendering is allowed. > > This comment seems redundant. I would just delete it. Removed. I'll upload a new patch. Created attachment 87594 [details]
Patch.
Updated with comments from Brett. Also I've included SKTypeface_win.h to address a FIXME.
Comment on attachment 87594 [details]
Patch.
ok.
The commit-queue encountered the following flaky tests while processing attachment 87594 [details]: fast/loader/recursive-before-unload-crash.html bug 50880 (authors: beidson@apple.com and eric@webkit.org) The commit-queue is continuing to process your patch. Comment on attachment 87594 [details] Patch. Clearing flags on attachment: 87594 Committed r82532: <http://trac.webkit.org/changeset/82532> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/82532 might have broken GTK Linux 32-bit Debug |