Bug 56441

Summary: Render fonts using skia when requested by platform context.
Product: WebKit Reporter: Chris Guillory <ctguil>
Component: PrintingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, brettw, commit-queue, dglazkov, eric, reed, scr, vandebo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Proposed patch.
none
Proposed patch.
none
Proposed patch.
none
Patch. none

Chris Guillory
Reported 2011-03-15 18:48:14 PDT
To support print preview in Chrome we need to render fonts using skia's text drawing APIs instead of using the native platform text drawing APIs. A previous change in Chromium enables this change: http://src.chromium.org/viewvc/chrome?view=rev&revision=77924
Attachments
Proposed patch. (7.61 KB, patch)
2011-03-16 05:21 PDT, Chris Guillory 		no flags
DetailsFormatted DiffDiff
Proposed patch. (7.61 KB, patch)
2011-03-22 19:01 PDT, Chris Guillory 		no flags
DetailsFormatted DiffDiff
Proposed patch. (8.09 KB, patch)
2011-03-22 19:08 PDT, Chris Guillory 		no flags
DetailsFormatted DiffDiff
Patch. (8.20 KB, patch)
2011-03-30 12:15 PDT, Chris Guillory 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Mike Reed
Comment 1 2011-03-16 04:46:24 PDT
What else needs to be done for this, outside of ENABLE(SKIA_TEXT) ?
Chris Guillory
Comment 2 2011-03-16 05:21:09 PDT
Created attachment 85923 [details] Proposed patch.
WebKit Review Bot
Comment 3 2011-03-16 05:28:58 PDT
Attachment 85923 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8188135
Chris Guillory
Comment 4 2011-03-22 19:01:19 PDT
Created attachment 86557 [details] Proposed patch. Linux build should succeed.
Chris Guillory
Comment 5 2011-03-22 19:08:42 PDT
Created attachment 86559 [details] Proposed patch.
Chris Guillory
Comment 6 2011-03-28 13:17:22 PDT
Brett can you have a look. The eventual goal is to always use skia on windows for drawing text but that will take some time.
Brett Wilson (Google)
Comment 7 2011-03-30 10:38:48 PDT
Comment on attachment 86559 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=86559&action=review LGTM > Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:266 > + // Check if native font rendering is allowed. This comment seems redundant. I would just delete it.
Chris Guillory
Comment 8 2011-03-30 11:59:51 PDT
(In reply to comment #7) > (From update of attachment 86559 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=86559&action=review > > LGTM > > > Source/WebCore/platform/graphics/skia/SkiaFontWin.cpp:266 > > + // Check if native font rendering is allowed. > > This comment seems redundant. I would just delete it. Removed. I'll upload a new patch.
Chris Guillory
Comment 9 2011-03-30 12:15:14 PDT
Created attachment 87594 [details] Patch. Updated with comments from Brett. Also I've included SKTypeface_win.h to address a FIXME.
Dimitri Glazkov (Google)
Comment 10 2011-03-30 14:48:37 PDT
Comment on attachment 87594 [details] Patch. ok.
WebKit Commit Bot
Comment 11 2011-03-30 18:50:58 PDT
The commit-queue encountered the following flaky tests while processing attachment 87594 [details]: fast/loader/recursive-before-unload-crash.html bug 50880 (authors: beidson@apple.com and eric@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 12 2011-03-30 18:53:35 PDT
Comment on attachment 87594 [details] Patch. Clearing flags on attachment: 87594 Committed r82532: <http://trac.webkit.org/changeset/82532>
WebKit Commit Bot
Comment 13 2011-03-30 18:53:40 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 14 2011-03-30 20:35:36 PDT
http://trac.webkit.org/changeset/82532 might have broken GTK Linux 32-bit Debug
Note You need to log in before you can comment on or make changes to this bug.