Bug 5643

Summary: setDragImage fails when passed Image object
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: JavaScriptCoreAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Return an NSImage instead
darin: review+
just for grins, here's the patch I meant none

Anders Carlsson
Reported 2005-11-06 06:29:34 PST
On debug builds, setDragImage fails with an assertion when the object passed in is an image. This is because KWQClipboard::dragNSImage incorrectly returns a WebImageRenderer object instead of an NSImage.
Attachments
Return an NSImage instead (1.87 KB, patch)
2005-11-06 06:32 PST, Anders Carlsson 		darin: review+
DetailsFormatted DiffDiff
just for grins, here's the patch I meant (43.81 KB, patch)
2005-11-06 12:07 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2005-11-06 06:32:32 PST
Created attachment 4612 [details] Return an NSImage instead
Darin Adler
Comment 2 2005-11-06 11:55:45 PST
Comment on attachment 4612 [details] Return an NSImage instead I've got a patch that includes this change and many others like this, already reviewed and ready to check in. But I haven't had a chance to land it yet.
Darin Adler
Comment 3 2005-11-06 12:07:49 PST
Created attachment 4615 [details] just for grins, here's the patch I meant Actually, it's not reviewed. I'll attach it here anyway.
Note You need to log in before you can comment on or make changes to this bug.