Bug 56349 – REGRESSION(80977): breaks Qt ARMv7 Linux Release bot

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Balazs Kelemen]

http://trac.webkit.org/changeset/80977 fails linking on this bot:
make[1]: Entering directory `/ramdisk/qt-linux-armv7-release/build/WebKitBuild/Release/QtTestBrowser'
...
obj/release/main.o: In function `initTestFonts()':
main.cpp:(.text+0x21c): undefined reference to `FcConfigGetFonts'
main.cpp:(.text+0x350): undefined reference to `FcConfigCreate'
main.cpp:(.text+0x384): undefined reference to `FcConfigParseAndLoad'
main.cpp:(.text+0x3c4): undefined reference to `FcConfigAppFontAddDir'
main.cpp:(.text+0x3e0): undefined reference to `FcConfigSetCurrent'
main.cpp:(.text+0x3ec): undefined reference to `FcConfigGetFonts'
collect2: ld returned 1 exit status

The same happens in our 64bit Arch Linux environment with Qt-4.7.0 (dunno what configuration has it built).
I guess it is happening if Qt does not link against fontconfig.

[Balazs Kelemen]

Created attachment 85749 [details]
Patch

[Adam Barth]

Comment on attachment 85749 [details]
Patch

rs=me

[Laszlo Gombos]

Comment on attachment 85749 [details]
Patch

I run into this as well, let's land it.

[WebKit Commit Bot]

Comment on attachment 85749 [details]
Patch

Rejecting attachment 85749 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'build-..." exit_code: 2

Last 500 characters of output:
......................................
tables/mozilla_expected_failures/other ..
transforms ....
transforms/2d ............
transforms/3d/general .....
transforms/3d/hit-testing ....
transforms/3d/point-mapping ........
transitions .................
transitions/interrupted-accelerated-transition.html -> failed

Exiting early after 1 failures. 21736 tests run.
523.78s total testing time

21735 test cases (99%) succeeded
1 test case (<1%) had incorrect layout
13 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/8174594

[Balazs Kelemen]

Comment on attachment 85749 [details]
Patch

Clearing flags on attachment: 85749

Committed r81139: <http://trac.webkit.org/changeset/81139>

[Balazs Kelemen]

All reviewed patches have been landed.  Closing bug.