Bug 56342

Summary: Leaks Viewer shows recent builds in a strange order
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: New BugsAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer, joepeck
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Adam Roben (:aroben)
Reported 2011-03-14 16:02:50 PDT
Leaks Viewer shows recent builds in a strange order
Attachments
Patch (2.03 KB, patch)
2011-03-14 16:04 PDT, Adam Roben (:aroben) 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-03-14 16:04:51 PDT
Created attachment 85735 [details] Patch
Joseph Pecoraro
Comment 2 2011-03-14 16:14:50 PDT
Comment on attachment 85735 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85735&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:80 > + if (a.revision < b.revision) > + return 1; > + if (b.revision < a.revision) > + return -1; > + return 0; How about: return a.revision - b.revision;
Joseph Pecoraro
Comment 3 2011-03-14 16:15:29 PDT
> > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:80 > > + if (a.revision < b.revision) > > + return 1; > > + if (b.revision < a.revision) > > + return -1; > > + return 0; > > How about: return a.revision - b.revision; Re-reading that I think I have a and b reversed.
Adam Roben (:aroben)
Comment 4 2011-03-14 16:17:52 PDT
Darin and I independently came up with the same suggestion. I've fixed it. Thanks!
Adam Roben (:aroben)
Comment 5 2011-03-14 16:18:12 PDT
Committed r81075: <http://trac.webkit.org/changeset/81075>
Note You need to log in before you can comment on or make changes to this bug.