Bug 56309

Summary:	Flaky tests caused by duplicated values when growing the hastables after r80582
Product:	WebKit	Reporter:	Alejandro G. Castro <alex>
Component:	WebKitGTK	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED FIXED
Severity:	Normal	CC:	andreip, hyatt, mrobinson, pnormand, zan
Priority:	P2
Version:	528+ (Nightly build)
Hardware:	PC
OS:	Linux

Alejandro G. Castro

Reported 2011-03-14 07:15:44 PDT

Apparently we are having the issues when reinserting values in the hashtable after growing it we had in bug 49781: #0 0x00002ab1e3214428 in WTF::HashTable<WebCore::FontPlatformData, std::pair<WebCore::FontPlatformData, std::pair<WebCore::SimpleFontData*, unsigned int> >, WTF::PairFirstExtractor<std::pair<WebCore::FontPlatformData, std::pair<WebCore::SimpleFontData*, unsigned int> > >, WebCore::FontDataCacheKeyHash, WTF::PairHashTraits<WebCore::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WebCore::SimpleFontData*, unsigned int> > >, WebCore::FontDataCacheKeyTraits>::reinsert (this=0x1d34170, entry=...) at ../../Source/JavaScriptCore/wtf/HashTable.h:760 #1 0x00002ab1e32133e7 in WTF::HashTable<WebCore::FontPlatformData, std::pair<WebCore::FontPlatformData, std::pair<WebCore::SimpleFontData*, unsigned int> >, WTF::PairFirstExtractor<std::pair<WebCore::FontPlatformData, std::pair<WebCore::SimpleFontData*, unsigned int> > >, WebCore::FontDataCacheKeyHash, WTF::PairHashTraits<WebCore::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WebCore::SimpleFontData*, unsigned int> > >, WebCore::FontDataCacheKeyTraits>::rehash (this=0x1d34170, newTableSize=512) at ../../Source/JavaScriptCore/wtf/HashTable.h:930 #2 0x00002ab1e3211d8f in WTF::HashTable<WebCore::FontPlatformData, std::pair<WebCore::FontPlatformData, std::pair<WebCore::SimpleFontData*, unsigned int> >, WTF::PairFirstExtractor<std::pair<WebCore::FontPlatformData, std::pair<WebCore::SimpleFontData*, unsigned int> > >, WebCore::FontDataCacheKeyHash, WTF::PairHashTraits<WebCore::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WebCore::SimpleFontData*, unsigned int> > >, WebCore::FontDataCacheKeyTraits>::expand (this=0x1d34170) at ../../Source/JavaScriptCore/wtf/HashTable.h:908 #3 0x00002ab1e320f8df in WTF::HashTable<WebCore::FontPlatformData, std::pair<WebCore::FontPlatformData, std::pair<WebCore::SimpleFontData*, unsigned int> >, WTF::PairFirstExtractor<std::pair<WebCore::FontPlatformData, std::pair<WebCore::SimpleFontData*, unsigned int> > >, WebCore::FontDataCacheKeyHash, WTF::PairHashTraits<WebCore::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WebCore::SimpleFontData*, unsigned int> > >, WebCore::FontDataCacheKeyTraits>::add<WebCore::FontPlatformData, std::pair<WebCore::SimpleFontData*, unsigned int>, WTF::HashMapTranslator<std::pair<WebCore::FontPlatformData, std::pair<WebCore::SimpleFontData*, unsigned int> >, WTF::PairHashTraits<WebCore::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WebCore::SimpleFontData*, unsigned int> > >, WebCore::FontDataCacheKeyHash> > (this=0x1d34170, key=..., extra=...) at ../../Source/JavaScriptCore/wtf/HashTable.h:700 #4 0x00002ab1e320cf45 in WTF::HashMap<WebCore::FontPlatformData, std::pair<WebCore::SimpleFontData*, unsigned int>, WebCore::FontDataCacheKeyHash, WebCore::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WebCore::SimpleFontData*, unsigned int> > >::inlineAdd (this=0x1d34170, key=..., mapped=...) at ../../Source/JavaScriptCore/wtf/HashMap.h:242 #5 0x00002ab1e320b203 in WTF::HashMap<WebCore::FontPlatformData, std::pair<WebCore::SimpleFontData*, unsigned int>, WebCore::FontDataCacheKeyHash, WebCore::FontDataCacheKeyTraits, WTF::HashTraits<std::pair<WebCore::SimpleFontData*, unsigned int> > >::set (this=0x1d34170, key=..., mapped=...) at ../../Source/JavaScriptCore/wtf/HashMap.h:249 #6 0x00002ab1e3209710 in WebCore::FontCache::getCachedFontData (this=0x154ebb0, platformData=0x1e31260) at ../../Source/WebCore/platform/graphics/FontCache.cpp:293 #7 0x00002ab1e32095a4 in WebCore::FontCache::getCachedFontData (this=0x154ebb0, fontDescription=..., family=..., checkingAlternateName=false) at ../../Source/WebCore/platform/graphics/FontCache.cpp:277 #8 0x00002ab1e2cc068e in WebCore::fontDataForGenericFamily (document=0x72052d0, fontDescription=..., familyName=...) at ../../Source/WebCore/css/CSSFontSelector.cpp:386 #9 0x00002ab1e2cc0a65 in WebCore::CSSFontSelector::getFontData (this=0x72fcf40, fontDescription=..., familyName=...) at ../../Source/WebCore/css/CSSFontSelector.cpp:477 #10 0x00002ab1e320a0a6 in WebCore::FontCache::getFontData (this=0x154ebb0, font=..., familyIndex=@0x73446c0, fontSelector=0x72fcf40) at ../../Source/WebCore/platform/graphics/FontCache.cpp:419 #11 0x00002ab1e3217b1d in WebCore::FontFallbackList::fontDataAt (this=0x7344630, font=0x7276568, realizedFontIndex=0) at ../../Source/WebCore/platform/graphics/FontFallbackList.cpp:105 #12 0x00002ab1e2a2610e in WebCore::FontFallbackList::primaryFontData (this=0x7344630, f=0x7276568) at ../../Source/WebCore/platform/graphics/FontFallbackList.h:66 #13 0x00002ab1e3217939 in WebCore::FontFallbackList::determinePitch (this=0x7344630, font=0x7276568) at ../../Source/WebCore/platform/graphics/FontFallbackList.cpp:76 #14 0x00002ab1e3335b15 in WebCore::FontFallbackList::isFixedPitch (this=0x7344630, f=0x7276568) at ../../Source/WebCore/platform/graphics/FontFallbackList.h:47 #15 0x00002ab1e3335b9d in WebCore::Font::isFixedPitch (this=0x7276568) at ../../Source/WebCore/platform/graphics/Font.h:267 #16 0x00002ab1e33334c1 in WebCore::RenderBlock::findNextLineBreak (this=0x7263518, resolver=..., firstLine=true, isLineEmpty=@0x7fff228bb67f, lineBreakIteratorInfo=..., previousLineBrokeCleanly=@0x7fff228bb6fa, hyphenated=@0x7fff228bb677, clear=0x7fff228bb678, lastFloatFromPreviousLine=0x0) at ../../Source/WebCore/rendering/RenderBlockLineLayout.cpp:1702 #17 0x00002ab1e332e283 in WebCore::RenderBlock::layoutInlineChildren (this=0x7263518, relayoutChildren=true, repaintLogicalTop=@0x7fff228bb9fc, repaintLogicalBottom=@0x7fff228bb9f8) at ../../Source/WebCore/rendering/RenderBlockLineLayout.cpp:692 #18 0x00002ab1e345abdf in WebCore::RenderBlock::forceLayoutInlineChildren (this=0x7263518) at ../../Source/WebCore/rendering/RenderBlock.h:317 #19 0x00002ab1e345a21c in WebCore::RenderSVGText::layout (this=0x7263518) at ../../Source/WebCore/rendering/svg/RenderSVGText.cpp:151 #20 0x00002ab1e3462ecc in WebCore::SVGRenderSupport::layoutChildren (start=0x72df008, selfNeedsLayout=true) at ../../Source/WebCore/rendering/svg/SVGRenderSupport.cpp:233 #21 0x00002ab1e3433c17 in WebCore::RenderSVGContainer::layout (this=0x72df008) at ../../Source/WebCore/rendering/svg/RenderSVGContainer.cpp:64 #22 0x00002ab1e3462ecc in WebCore::SVGRenderSupport::layoutChildren (start=0x734b258, selfNeedsLayout=true) at ../../Source/WebCore/rendering/svg/SVGRenderSupport.cpp:233 #23 0x00002ab1e3457902 in WebCore::RenderSVGRoot::layout (this=0x734b258) at ../../Source/WebCore/rendering/svg/RenderSVGRoot.cpp:119 http://webkit-bots.igalia.com/amd64/svn_81017.core-when_1300106130-_-who_DumpRenderTree-_-why_11.trace.html

Attachments
Add attachment proposed patch, testcase, etc.

Martin Robinson

Comment 1 2011-03-14 08:44:56 PDT

(In reply to comment #0) > Apparently we are having the issues when reinserting values in the hashtable after growing it we had in bug 49781: Ugh. Is there any way to reproduce this consistently?

Alejandro G. Castro

Comment 2 2011-03-14 09:07:33 PDT

(In reply to comment #1) > (In reply to comment #0) > > Apparently we are having the issues when reinserting values in the hashtable after growing it we had in bug 49781: > > Ugh. Is there any way to reproduce this consistently? Unfourtunately, I could not, like the former situation. Btw it also happens in chromium apparently: bug 56051. Andrei, could you paste the backtrace to check if it is the same problem?

Martin Robinson

Comment 3 2011-03-14 16:12:59 PDT

I suspect this is a duplciate of https://bugs.webkit.org/show_bug.cgi?id=48723 and perhaps also https://bugs.webkit.org/show_bug.cgi?id=56329 .

Martin Robinson

Comment 4 2011-03-14 16:13:12 PDT

I suspect this is a duplicate of https://bugs.webkit.org/show_bug.cgi?id=48723 and perhaps also https://bugs.webkit.org/show_bug.cgi?id=56329 .

Philippe Normand

Comment 5 2011-03-29 05:52:39 PDT

svg/text/text-deco-01-b.svg consistently crashes on 64-bits Debug because of this bug. I'll skip it for now.

Zan Dobersek

Comment 6 2012-07-15 10:36:09 PDT

(In reply to comment #5) > svg/text/text-deco-01-b.svg consistently crashes on 64-bits Debug because of this bug. I'll skip it for now. The issue seems to have been fixed and the test no longer crashes, its expectation being removed in http://trac.webkit.org/changeset/118474. Closing the bug.

Note You need to log in before you can comment on or make changes to this bug.