| Summary: | REGRESSION(r80892): 100,000+ leaks seen on the build bot | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Rowe (bdash) <mrowe> | ||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | adauria, barraclough, beidson, ggaren, levin, oliver | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| URL: | http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r81011%20(15552)/ | ||||||
| Attachments: |
|
||||||
|
Description
Mark Rowe (bdash)
2011-03-14 05:14:19 PDT
The reason for this is that r80892 adds duplicate static function entries to the JSClassDefinition in DumpRenderTree’s LayoutTestController.cpp. This appears to cause JavaScriptCore to leak each of the duplicates. This is triggered every time the window object is cleared (once per frame per test?). Created attachment 85668 [details]
Patch
The explicit calls to StringImpl::ref seem as though they will also result in leaks as there are no matching calls to StringImpl::deref anywhere. The patch removes those as well as fixing the bigger issue of the leaked duplicate entries.
|