Summary: | WebKitIconDatabase may trigger crash in cairoImageSurfaceToGdkPixbuf | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Christian Dywan <christian> | ||||
Component: | WebKitGTK | Assignee: | Christian Dywan <christian> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Major | CC: | svillar | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Christian Dywan
2011-03-11 09:17:11 PST
Created attachment 85487 [details]
Don't attempt to make a pixbuf if there is no image
(In reply to comment #1) > Created an attachment (id=85487) [details] > Don't attempt to make a pixbuf if there is no image BTW I got the same with a ephy patched version Comment on attachment 85487 [details] Don't attempt to make a pixbuf if there is no image View in context: https://bugs.webkit.org/attachment.cgi?id=85487&action=review Looks good. Does this fix the crasher or are there more? > Source/WebCore/platform/graphics/gtk/ImageGtk.cpp:157 > + if (!frameAtIndex(currentFrame())) > + return 0; > return cairoImageSurfaceToGdkPixbuf(frameAtIndex(currentFrame())); Please make this simple change before landing. cairo_surface_t* frame = frameAtIndex(currentFrame()); if (!frame) return 0; return cairoImageSurfaceToGdkPixbuf(frame); |